Skip to content

Use vscode ui components #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreineckearm merged 3 commits into from
Mar 31, 2025
Merged

Use vscode ui components #51

jreineckearm merged 3 commits into from
Mar 31, 2025

Conversation

@haydar-metin
Copy link
Contributor

@haydar-metin haydar-metin commented Feb 27, 2025 •
edited
Loading

@haydar-metin haydar-metin mentioned this pull request Feb 27, 2025
Merged
@haydar-metin haydar-metin marked this pull request as draft March 11, 2025 08:56
@jreineckearm
Copy link
Contributor

jreineckearm commented Mar 16, 2025

Tried the PR in combination with the new view. Worked nicely.
However, won't do a full code review just yet. But wait for any pending changes and merge actions from other PRs.

@haydar-metin haydar-metin mentioned this pull request Mar 28, 2025
Merged
jreineckearm
jreineckearm requested changes Mar 29, 2025
View reviewed changes
jreineckearm
jreineckearm reviewed Mar 29, 2025
View reviewed changes
Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two additional questions.

jreineckearm
jreineckearm reviewed Mar 29, 2025
View reviewed changes
@jreineckearm jreineckearm mentioned this pull request Mar 29, 2025
Closed
@jreineckearm
Copy link
Contributor

jreineckearm commented Mar 29, 2025

We should merge this only after #59 .

While testing didn't show any regressions yet, I'd like this big change to settle for a couple of days on main. At the same time, I'd like to get a number of great functionality changes to the public ASAP. For which #59 prepares a release.

@haydar-metin haydar-metin marked this pull request as ready for review March 31, 2025 12:20
jreineckearm
jreineckearm approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes look good to me!
Let's merge and let this settle a bit before the next release. This gives us time to further test it.

@jreineckearm jreineckearm merged commit d6534d8 into eclipse-cdt-cloud:main Mar 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreineckearm jreineckearm jreineckearm approved these changes

@planger planger Awaiting requested review from planger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@haydar-metin @jreineckearm