Migrate editing, polling and resizing functionality #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydar-metin
force-pushed
the
migrate-peripheral-inspector-v2
branch
from
456f17f to
1b8bfce
Compare
Contributor
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Two minor things to look at. Then good to merge.
Realized only during this review how much thought went into a couple of APIs and the architecture. May only move some things around and rename some folders in future. But mainly cosmetics which can be done after initial release. Amazing job!
jreineckearm
approved these changes
Mar 31, 2025
Contributor
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the updates.
See comment about updating the lock file in #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates new functionality implemented in the peripheral inspector.
How to test: eclipse-cdt-cloud/vscode-peripheral-inspector#51