feat: comment on auto-merge problems#603
feat: comment on auto-merge problems#603AlexanderLanin wants to merge 5 commits intoeclipse-csi:mainfrom
Conversation
AlexanderLanin
force-pushed
the
merge_prob
branch
from
ab9b48e to
10834bf
Compare
There was a problem hiding this comment.
Pull request overview
Adds user-facing feedback when /otterdog merge cannot proceed, by collecting eligibility problems and posting them as a PR comment.
Changes:
- Introduces a new “automerge problems” comment template to list reasons auto-merge is blocked.
- Refactors merge pre-checks to return a list of blocking reasons and post them as a PR comment.
- Adds
PullRequestModel.automerge_problems()and re-implementscan_be_automerged()in terms of it.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| otterdog/webapp/templates/comment/wrong_user_merge_comment.txt | Removes the old single-purpose warning template. |
| otterdog/webapp/templates/comment/automerge_problems.txt | Adds a new template intended to list auto-merge blocking reasons. |
| otterdog/webapp/tasks/merge_pull_request.py | Collects auto-merge eligibility problems and posts them to the PR when merge is skipped. |
| otterdog/webapp/db/models.py | Adds an API to enumerate auto-merge blocking reasons and updates eligibility logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexanderLanin
force-pushed
the
merge_prob
branch
from
10834bf to
c1d4d40
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexanderLanin
force-pushed
the
merge_prob
branch
from
c1d4d40 to
f8e09c1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
If merged, please squash as the commits are meaningless. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@AlexanderLanin only squash or rebase is enabled for merging PRs and I usually squash commits from a PR when merging. |
|
could you add a changelog entry? If I edit the PR myself, I cant merge afterwards. |
|
@netomi done. I assumed that would be 1.3.0 then. |
closes #602