Skip to content

Conversation

@arunjose696
Copy link
Contributor

@arunjose696 arunjose696 commented Nov 25, 2025

The showSplash method was adapted in 3ba28b7 to bring the scaling logic back in sync with org.eclipse.swt.internal.DPIUtil. During this change, the upper limit for the autoscale value (200) was taken directly from SWT and added in showSplash. However, following eclipse-platform/eclipse.platform.swt#111, the SWT.autoscale upper limit was removed.

This change removes the upper limit here as well, ensuring the scaling logic remains consistent and the splash screen renders correctly across different DPI settings.

This Fixes eclipse-platform/eclipse.platform.swt#2792

Steps to reproduce the fix:

1)Clone the repo and run /org.eclipse.equinox.executable.feature/library/win32/build.bat to generate eclipse_11916.dll.
2)Download a eclipse ibuild and extract its contents to <ECLIPSE_INSTALL_DIR>
3)Then, copy the DLL file in step 1 to <ECLIPSE_INSTALL_DIR>/plugins/<EQUINOX_LAUNCHER_FOLDER>.

Start the IDE in ibuild at 300% zoom. Without this change, the issue mentioned in eclipse-platform/eclipse.platform.swt#2792 would appear.

before

old.mp4

with the change

new.mp4

@amartya4256
Copy link

@arunjose696 the build is failing. I think you need a version bump in equinox.

@arunjose696 arunjose696 force-pushed the arunjose696/545/RemoveUpperLimit branch from 105e1ed to 50b19ce Compare January 5, 2026 09:47
@arunjose696
Copy link
Contributor Author

arunjose696 commented Jan 5, 2026

@arunjose696 the build is failing. I think you need a version bump in equinox.

I have rebased on master which has the version bumps.

@laeubi or @akurtakov could you please approve the workflows

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Test Results

  846 files  ±0    846 suites  ±0   1h 50m 48s ⏱️ -53s
2 234 tests ±0  2 185 ✅ ±0   49 💤 ±0  0 ❌ ±0 
6 702 runs  ±0  6 553 ✅ ±0  149 💤 ±0  0 ❌ ±0 

Results for commit b0faf6b. ± Comparison against base commit 1cc2026.

♻️ This comment has been updated with latest results.

The showSplash method was adapted in 3ba28b7 to bring the scaling logic back in sync with org.eclipse.swt.internal.DPIUtil. Previously, the upper limit for the autoscale value (200) was taken directly from SWT. However, following  eclipse-platform/eclipse.platform.swt#111, the SWT.autoscale upper limit was removed.

This change removes the upper limit here as well, ensuring the scaling logic remains consistent and the splash screen renders correctly across different DPI settings.
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment in this method correctly states:

this implementation needs to be kept in sync with org.eclipse.swt.internal.DPIUtil#setDeviceZoom(int)

That did not happen after eclipse-platform/eclipse.platform.swt#111 (and unfortunately SWT documentation was also not properly updated with that change and just recently adapted: eclipse-platform/eclipse.platform.swt#2945).

This change properly aligns the image size used by the native launcher with the SWT settings again.

@akurtakov @HannesWell maybe one of you can process this PR?

@akurtakov
Copy link
Member

@eclipse-equinox/eclipse-equinox-project-leads I propose nominating @HeikoKlare for committer so he can take care of such Windows specific changes unless you have another plan how to handle such PRs.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change properly aligns the image size used by the native launcher with the SWT settings again.

Sounds reasonable.

Thanks for this.

@HannesWell HannesWell merged commit b59e1d9 into eclipse-equinox:master Jan 11, 2026
30 checks passed
@HeikoKlare HeikoKlare deleted the arunjose696/545/RemoveUpperLimit branch January 12, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Splash screen (image) wrongly scaled on specific zooms Splash Screen scaling issue on Windows with 300% OS level zoom

5 participants