-
Notifications
You must be signed in to change notification settings - Fork 83
Remove autoscale upper limit to match SWT DPIUtil #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove autoscale upper limit to match SWT DPIUtil #1213
Conversation
|
@arunjose696 the build is failing. I think you need a version bump in equinox. |
105e1ed to
50b19ce
Compare
I have rebased on master which has the version bumps. @laeubi or @akurtakov could you please approve the workflows |
50b19ce to
cacbf5d
Compare
The showSplash method was adapted in 3ba28b7 to bring the scaling logic back in sync with org.eclipse.swt.internal.DPIUtil. Previously, the upper limit for the autoscale value (200) was taken directly from SWT. However, following eclipse-platform/eclipse.platform.swt#111, the SWT.autoscale upper limit was removed. This change removes the upper limit here as well, ensuring the scaling logic remains consistent and the splash screen renders correctly across different DPI settings.
972f7e9 to
b0faf6b
Compare
HeikoKlare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment in this method correctly states:
this implementation needs to be kept in sync with org.eclipse.swt.internal.DPIUtil#setDeviceZoom(int)
That did not happen after eclipse-platform/eclipse.platform.swt#111 (and unfortunately SWT documentation was also not properly updated with that change and just recently adapted: eclipse-platform/eclipse.platform.swt#2945).
This change properly aligns the image size used by the native launcher with the SWT settings again.
@akurtakov @HannesWell maybe one of you can process this PR?
|
@eclipse-equinox/eclipse-equinox-project-leads I propose nominating @HeikoKlare for committer so he can take care of such Windows specific changes unless you have another plan how to handle such PRs. |
HannesWell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change properly aligns the image size used by the native launcher with the SWT settings again.
Sounds reasonable.
Thanks for this.
The
showSplashmethod was adapted in 3ba28b7 to bring the scaling logic back in sync withorg.eclipse.swt.internal.DPIUtil. During this change, the upper limit for the autoscale value (200) was taken directly fromSWTand added inshowSplash. However, following eclipse-platform/eclipse.platform.swt#111, theSWT.autoscaleupper limit was removed.This change removes the upper limit here as well, ensuring the scaling logic remains consistent and the splash screen renders correctly across different DPI settings.
This Fixes eclipse-platform/eclipse.platform.swt#2792
Steps to reproduce the fix:
1)Clone the repo and run /org.eclipse.equinox.executable.feature/library/win32/build.bat to generate eclipse_11916.dll.
2)Download a eclipse ibuild and extract its contents to <ECLIPSE_INSTALL_DIR>
3)Then, copy the DLL file in step 1 to <ECLIPSE_INSTALL_DIR>/plugins/<EQUINOX_LAUNCHER_FOLDER>.
Start the IDE in ibuild at 300% zoom. Without this change, the issue mentioned in eclipse-platform/eclipse.platform.swt#2792 would appear.
before
old.mp4
with the change
new.mp4