Skip to content

Conversation

@patdhlk
Copy link
Contributor

@patdhlk patdhlk commented Jan 5, 2026

  1. Iox2Log.cs
  • Updated class-level documentation with details about v0.8.0 logging changes
  • Added list of available loggers (console, buffer, file, log, tracing)
  • Added build instructions for enabling file logger
  • UseConsoleLogger(): Marked as [Obsolete], now returns true (no-op since console is default)
  • UseFileLogger(): Marked as [Obsolete], throws NotSupportedException with instructions for alternatives
  1. Iox2NativeMethods.cs
  • Removed P/Invoke declarations for iox2_use_console_logger() and iox2_use_file_logger()
  • Added comments explaining these were removed in v0.8.0
  1. examples/Logging/Program.cs
  • Updated basic example to note console logger is now default
  • Removed call to UseConsoleLogger() (no longer needed) -Rewrote file logger example to use a custom logger callback that writes to file
  1. examples/Logging/README.md
  • Added new section explaining v0.8.0 logging backend changes
  • Listed available loggers and their feature flags
  • Added build instructions for enabling native file logger
  • Updated API usage examples to reflect new behavior
  1. examples/LoggingIntegration/README.md Added note about v0.8.0 changes and that SetLogger() continues to work

#5

1. Iox2Log.cs
- Updated class-level documentation with details about v0.8.0 logging changes
- Added list of available loggers (console, buffer, file, log, tracing)
- Added build instructions for enabling file logger
- UseConsoleLogger(): Marked as [Obsolete], now returns true (no-op since console is default)
- UseFileLogger(): Marked as [Obsolete], throws NotSupportedException with instructions for alternatives

2. Iox2NativeMethods.cs
- Removed P/Invoke declarations for iox2_use_console_logger() and iox2_use_file_logger()
- Added comments explaining these were removed in v0.8.0

3. examples/Logging/Program.cs
- Updated basic example to note console logger is now default
- Removed call to UseConsoleLogger() (no longer needed)
 -Rewrote file logger example to use a custom logger callback that writes to file

4. examples/Logging/README.md
- Added new section explaining v0.8.0 logging backend changes
- Listed available loggers and their feature flags
- Added build instructions for enabling native file logger
- Updated API usage examples to reflect new behavior

5. examples/LoggingIntegration/README.md
Added note about v0.8.0 changes and that SetLogger() continues to work
@dkroenke dkroenke self-requested a review January 6, 2026 09:30
@dkroenke
Copy link
Member

dkroenke commented Jan 6, 2026

Some documentation nitpicks from the examples:

Copy link
Member

@dkroenke dkroenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the Logging Example is functional. From my side this PR is ready to review so that we can run the CI.

@patdhlk patdhlk marked this pull request as ready for review January 7, 2026 15:41
@dkroenke dkroenke self-requested a review January 7, 2026 16:45
Copy link
Member

@dkroenke dkroenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dkroenke dkroenke merged commit bfe237d into eclipse-iceoryx:main Jan 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants