-
Notifications
You must be signed in to change notification settings - Fork 163
Sealed and non-sealed modifiers and permitted types not accessible through ITypeBinding #3252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e45f07a to
178a88c
Compare
org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/TypeBinding.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.core/dom/org/eclipse/jdt/core/dom/TypeBinding.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverter_23Test.java
Show resolved
Hide resolved
org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverter_23Test.java
Show resolved
Hide resolved
178a88c to
b254639
Compare
3120cff to
a4905a8
Compare
a4905a8 to
4c34193
Compare
66b4620 to
e2e26dd
Compare
|
@subyssurendran666 The patch looks good, however, I just noticed that we need to handle interface + sealed as well. For e.g, consider the below code: Querying isSealed() on A is going to return false. I think in the getModifiers(), we should do similar fix in isInterface() branch also. |
42ee04d to
19b51e0
Compare
I have a incorporated the changes. Thanks for the suggestions. |
org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverter_23Test.java
Show resolved
Hide resolved
19b51e0 to
14f867a
Compare
for sealed and non-sealed modifiers
14f867a to
4b39e64
Compare
4b39e64 to
f00c9f0
Compare
…rough ITypeBinding (eclipse-jdt#3252) Look for sealed and non-sealed attributes from compiler binding and set the bits accordingly in the DOM type binding.
Added the unit tests and added the modifiers to the resolve bindings for sealed and non-sealed modifiers
What it does
The 'sealed' and 'non-sealed' modifiers are visible and accessible through the AST, but not when trying to get the same information with the associated type binding. Therefore added the modifiers in the TypeBiding for the sealed and non-sealed modifiers.
How to test
This PR closes #3178
Author checklist