Enhanced switch v2.0 - Part I

[srikanth-sankaran]

• Reimplement resolution, analysis and bookkeeping involved with CaseStatement and resolution of SwitchStatement for a streamlined and cleaner implementation resulting in readily obvious control flow and minimization of state.

• Report non-constant label expressions during resolution rather than waiting for flow analysis phase.

• Change how duplicate label expressions are reported. Don't blame the whole case, just the duplicate expression; Don't blame the original, just the duplicate.

• Represent qualified enumerators with qualified names internally so to avoid name clashes

• Eliminate the hack to inject synthetic BreakStatement in label rule switch blocks. Enhance the code generator to handle these explicitly.

• Simplify the implementation of SwitchStatement.getFallThroughState correcting various issues.

• Eliminate the unnecessary vector SwitchStatement.constMapping that is passed to org.eclipse.jdt.internal.compiler.codegen.CodeStream.tableswitch - constanMapping[i] == i always!

• Enable various tests in PrimitiveInPatternsTest.java that were disabled, fixing broken tests; Remove their disabled cousins from PrimitiveInPatternsTestSH.java

• Add a disabled regression test for [Enhanced Switch][Null] Inconsistent nullness propagation #3319 (not yet understood/fixed)

• Numerous defect fixes as listed below

• Fixes [Enhanced Switch][Primitive Patterns] Bogus error: Case constants in a switch on 'Long' must have type 'long' #3336

• Fixes [Enhanced Switch] ECJ tolerates fall through to default from a case with pattern label while javac rejects it. #3318

• Fixes [Enhanced Switch][Patterns] ECJ generated code hangs #3320

• Fixes [Enhanced Switch] ECJ uses 3 secret variables where just one (or even zero in most cases) would do  #3321

• Fixes [Enhanced Switch] Bogus duplicate case error from ECJ #3334

• Fixes [Enhanced Switch][Record Patterns] ECJ compiles non-exhaustive switch resulting in MatchException being thrown at runtime #3335

• Fixes [Primitive Patterns] Wrong duplicate case error  #3265

• Fixes [21][Enhanced Switch] Bogus error: "Cannot mix pattern with other case labels" #3169

• Fixes [Enhanced Switch][Regression] Incorrect duplicate case error since https://github.com/eclipse-jdt/eclipse.jdt.core/pull/3264 #3339

• Fixes [Enhanced Switch][Primitive Patterns] ECJ tolerates default case in boolean switch with both true and false cases. #3337

• Fixes [Enhanced Switch] Problem with switch and enums - incorrect duplicate case error #3344

[eclipse-jdt-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

org.eclipse.jdt.core/META-INF/MANIFEST.MF
org.eclipse.jdt.core/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From e987a4db3c6d524ee9c45ce96e5cb9c9071eb97a Mon Sep 17 00:00:00 2001
From: Eclipse JDT Bot <[email protected]>
Date: Mon, 25 Nov 2024 18:04:40 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/org.eclipse.jdt.core/META-INF/MANIFEST.MF b/org.eclipse.jdt.core/META-INF/MANIFEST.MF
index 0a624e97aa..8fc000b414 100644
--- a/org.eclipse.jdt.core/META-INF/MANIFEST.MF
+++ b/org.eclipse.jdt.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jdt.core; singleton:=true
-Bundle-Version: 3.40.0.qualifier
+Bundle-Version: 3.40.100.qualifier
 Bundle-Activator: org.eclipse.jdt.core.JavaCore
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/org.eclipse.jdt.core/pom.xml b/org.eclipse.jdt.core/pom.xml
index 66baa177d4..856bb48399 100644
--- a/org.eclipse.jdt.core/pom.xml
+++ b/org.eclipse.jdt.core/pom.xml
@@ -17,7 +17,7 @@
     <version>4.35.0-SNAPSHOT</version>
   </parent>
   <artifactId>org.eclipse.jdt.core</artifactId>
-  <version>3.40.0-SNAPSHOT</version>
+  <version>3.40.100-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 
   <properties>
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[srikanth-sankaran]

This pull request changes some projects for the first time in this development cycle. Therefore the following files need a version increment:

org.eclipse.jdt.core/META-INF/MANIFEST.MF
org.eclipse.jdt.core/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
Further information are available in Common Build Issues - Missing version increments.

@HannesWell , I hear from @iloveeclipse that this automatic increment of versions in the new development cycle is your contribution. It used to irritate me to have to do that manually - thank you so much for this feature 👍 👏

[akurtakov]

Do we expect comparator issues coming from this one? If yes, I would rather start an I-build now so they can be looked at today.

[srikanth-sankaran]

Do we expect comparator issues coming from this one? If yes, I would rather start an I-build now so they can be looked at today.

I doubt it - there are some class file and code generation changes for sure particularly in the context of #3321 but that likely affects only Java 21 sources.

That we didn't see any comparator issues in jdt's own CI build is a sign.

All that said, this is a massive, near complete rewrite of various portions of switch/case handling.
Why don't we get started sooner - yes, please trigger an I-Build now so we will know for sure.

Thanks very much @akurtakov

[akurtakov]

Here it is https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/4/

[srikanth-sankaran]

04:38:30 [ERROR] Cannot resolve dependencies of project org.eclipse.platform.feature:org.eclipse.platform:eclipse-feature:4.35.0-SNAPSHOT
04:38:30 [ERROR] with context {osgi.os=linux, org.eclipse.update.install.features=true, osgi.arch=x86_64, org.eclipse.update.install.sources=true, osgi.ws=gtk, org.eclipse.jdt.buildtime=true}
04:38:30 [ERROR] Software being installed: org.eclipse.platform.feature.group 4.35.0.qualifier
04:38:30 [ERROR] Missing requirement: org.eclipse.help.feature.group 2.3.2100.v20241126-0613 requires 'org.eclipse.equinox.p2.iu; org.eclipse.help.base [4.4.700.v20241126-0110,4.4.700.v20241126-0110]' but it could not be found
04:38:30 [ERROR] Cannot satisfy dependency: org.eclipse.platform.feature.group 4.35.0.qualifier depends on: org.eclipse.equinox.p2.iu; org.eclipse.help.feature.group 0.0.0: See log for details
04:38:30 [ERROR] -> [Help 1]

Not sure if this is the root problem

If a rebuild is triggered, we may as well include the commit srikanth-sankaran@1cf69bb that just got merged -

[srikanth-sankaran]

04:38:30 [ERROR] Cannot resolve dependencies of project org.eclipse.platform.feature:org.eclipse.platform:eclipse-feature:4.35.0-SNAPSHOT 04:38:30 [ERROR] with context {osgi.os=linux, org.eclipse.update.install.features=true, osgi.arch=x86_64, org.eclipse.update.install.sources=true, osgi.ws=gtk, org.eclipse.jdt.buildtime=true} 04:38:30 [ERROR] Software being installed: org.eclipse.platform.feature.group 4.35.0.qualifier 04:38:30 [ERROR] Missing requirement: org.eclipse.help.feature.group 2.3.2100.v20241126-0613 requires 'org.eclipse.equinox.p2.iu; org.eclipse.help.base [4.4.700.v20241126-0110,4.4.700.v20241126-0110]' but it could not be found 04:38:30 [ERROR] Cannot satisfy dependency: org.eclipse.platform.feature.group 4.35.0.qualifier depends on: org.eclipse.equinox.p2.iu; org.eclipse.help.feature.group 0.0.0: See log for details 04:38:30 [ERROR] -> [Help 1]

Not sure if this is the root problem

If a rebuild is triggered, we may as well include the commit srikanth-sankaran@1cf69bb that just got merged -

I meant this commit: 1cf69bb

[srikanth-sankaran]

@akurtakov - I am not familiar with the build set up so unable to analyze the next steps ...

[akurtakov]

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.35/6/consoleFull went beyond the previous failures. For the record - I-builds always use master of all submodules so this commit should be included in this build.

[HannesWell]

Git patch
Further information are available in Common Build Issues - Missing version increments.

@HannesWell , I hear from @iloveeclipse that this automatic increment of versions in the new development cycle is your contribution. It used to irritate me to have to do that manually - thank you so much for this feature 👍 👏

You are very welcome and thanks for the nice words. I'm glad it it's helpful. :)
But you also have to thank @laeubi who created the foundations in Tycho on top of which the workflows are built.

[srikanth-sankaran]

Thanks to you too @laeubi 👍