Skip to content

Conversation

@gzsombor
Copy link
Contributor

@gzsombor gzsombor commented Apr 3, 2025

  • if marked with custom
  • if we have the source file - a test/prod code
  • platform code
  • synthetic methods
  • library code
  • unknown

What it does

Fixes #658

How to test

Debug the following code:

public class Bug {
	public static void main(String[] args) {
		var in = new Inner(m -> {
			System.out.println("hello " + m); /// breakpoint here
		});
		for (int i = 0; i < 3; i++) {
			in.innerCall("world " + i);
		}
	}

	record Inner(Consumer<String> li) {
		void innerCall(String msg) {
			li.accept(msg);
		}
	}
}

Check that the stack frames are sensible and correctly displayed

Author checklist

* if marked with custom
* if we have the source file - a test/prod code
* platform code
* synthetic methods
* library code
* unknown
@iloveeclipse
Copy link
Member

@gzsombor : could you add tests for the stack frames categorization to cover known expectations? The change looks fine for this concrete use case, but honestly speaking, it might cause regressions in other use cases I didn't tested manually, and without tests we would only know about regression after someone reports that in the released version.

@iloveeclipse iloveeclipse merged commit 5d926a5 into eclipse-jdt:master Apr 7, 2025
11 checks passed
@gzsombor gzsombor deleted the change-order-of-frame-categories branch April 9, 2025 05:51
@gzsombor
Copy link
Contributor Author

gzsombor commented Apr 9, 2025

There are tests in #81 and I had to modify it due this change. It's not much but touches enough relevant code IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lambda code is not properly recognized as project code in debugger

2 participants