Skip to content

Change the priority of the categorization #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Change the priority of the categorization #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/StackFrameCategorizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,17 +165,24 @@ public IJavaStackFrame.Category categorize(IJavaStackFrame frame) {
if (isEnabled(CATEGORY_CUSTOM_FILTERED) && custom.match(refTypeName)) {
return CATEGORY_CUSTOM_FILTERED;
}
Category category = categorizeSourceElement(frame);
// if the category is prod or test, that's the most relevant.
if (category == CATEGORY_PRODUCTION || category == CATEGORY_TEST) {
return category;
}

if (isEnabled(CATEGORY_SYNTHETIC) && frame.isSynthetic()) {
return CATEGORY_SYNTHETIC;
}
if (isEnabled(CATEGORY_PLATFORM) && platform.match(refTypeName)) {
return CATEGORY_PLATFORM;
}
// Maybe comes from a library or it's unknown.
return category;
} catch (DebugException de) {
JDIDebugUIPlugin.log(de);
return CATEGORY_UNKNOWN;
}

return categorizeSourceElement(frame);
}

/**
Expand Down
Loading