Defer accessing instance preferences until service is registered #686
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kwin
commented
Apr 30, 2025
| fWorkspaceServiceTracker.open(); | ||
|
|
||
| InstanceScope.INSTANCE.getNode(ID_PLUGIN).addPreferenceChangeListener(this); | ||
| Filter instanceLocationFilter = context.createFilter("(&(objectClass=" + Location.class.getName() + ")(" + Location.SERVICE_PROPERTY_TYPE //$NON-NLS-1$ //$NON-NLS-2$ |
Contributor
Author
There was a problem hiding this comment.
This is unfortunately not the right condition: eclipse-equinox/equinox#932. Unclear how to defer until the workspace is set (i.e. the instance config is being set).
registered Otherwise one might run into "ISE: The instance data location has not been specified yet." depending on the bundle start order Also only register workspace change listener when workspace service is available. This closes eclipse-jdt#684
kwin
force-pushed
the
bugfix/use-service-tracker-to-defer-accessing-instance-preferences
branch
from
b672b4c to
039caef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise one might run into "ISE: The instance data location has not been specified yet." depending on the bundle start order Also only register workspace change listener when workspace service is available.
This closes #684
What it does
How to test
Author checklist