Skip to content

Match also junit-platform-commons-* file name when detecting a JUnit 6 launch type#2626

Merged
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
trancexpress:gh2625
Nov 10, 2025
Merged

Match also junit-platform-commons-* file name when detecting a JUnit 6 launch type#2626
iloveeclipse merged 1 commit intoeclipse-jdt:masterfrom
trancexpress:gh2625

Conversation

@trancexpress
Copy link
Contributor

Fixes: #2625

What it does

How to test

Author checklist

@trancexpress
Copy link
Contributor Author

@iloveeclipse this is one problem I see so far with eclipse-pde/eclipse.pde#2109. I ran tests from Eclipse (see: eclipse-pde/eclipse.pde#2024 (comment)) and they are green now, with the JUnit 6 changes in PDE. Hopefully we don't have to change anything else to get the PDE changes merged.

@trancexpress
Copy link
Contributor Author

Doesn't look like the fails are related:

Annotations

[Check warning on line 887 in org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/jarpackager/JarPackageData.java](https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/2626/files#annotation_41383858068)

@jenkins-eclipse-jdt jenkins-eclipse-jdt / Compiler

Deprecation

NORMAL:
The type JarWriter2 has been deprecated since version 2024-12 and marked for removal

[Check warning on line 888 in org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/jarpackager/JarPackageData.java](https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/2626/files#annotation_41383858077)

@jenkins-eclipse-jdt jenkins-eclipse-jdt / Compiler

Deprecation

NORMAL:
The type JarWriter2 has been deprecated since version 2024-12 and marked for removal

[Check warning on line 322 in org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/text/JavaTextTools.java](https://github.com/eclipse-jdt/eclipse.jdt.ui/pull/2626/files#annotation_41383858086)

@jenkins-eclipse-jdt jenkins-eclipse-jdt / Compiler

Deprecation

NORMAL:
The type DefaultPartitioner has been deprecated since version 2025-03 and marked for removal

@iloveeclipse
Copy link
Member

Doesn't look like the fails are related:

I've created eclipse-jdt/eclipse.jdt.core#4607.

@iloveeclipse iloveeclipse merged commit c4622eb into eclipse-jdt:master Nov 10, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launch type not correctly detected during PDE tests

2 participants

Comments