-
Notifications
You must be signed in to change notification settings - Fork 121
Support JUnit 6 plug-in test launches #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
First error I run into: The available bundles seem fine... Maybe something to do with the removal of |
Test Results 774 files + 3 774 suites +3 56m 55s ⏱️ + 5m 16s For more details on these failures, see this check. Results for commit 1ab5883. ± Comparison against base commit b00ef59. ♻️ This comment has been updated with latest results. |
|
Next error is: |
|
@trancexpress we have added some import restirctions on some other parts of PDE/JDT that are used here. Beside that, I would like to first see a successful run in pure JDT (is this already possible?) and maybe one should delay PDE support to next release... it really do not bring any value right now. |
I'll check what needs to change, no problem.
Only with the 2 PRs linked in #2108:
The SDK build is broken, so we cannot merge either. But once we merge them, yes, plain JUnit tests run with JUnit 6.
We would have to add some sort of validation on the launch, and more. Right now the launch defaults to JUnit 6, as soon as eclipse-jdt/eclipse.jdt.ui#2560 is used. For plug-in tests we'll need to filter out the JUnit 6 option, if we are delaying PDE support by a release. How much time do we have @iloveeclipse ? |
Ideally "bigger" changes should be done before M3 planned for next thursday/friday. |
|
With the latest changes here, as well as eclipse-jdt/eclipse.jdt#145 and |
With JUnit 5, correct? Because it is what manifest says. |
|
@laeubi it would be great if you can take a look. If you think we should delay JUnit 6 support until the next release, so that we get more manual testing, I think that would be fine as well. But we'll need to disable the plug-in test launch JUnit 6 choice. Unless we delay the entire JUnit 6 choice in launches. |
One set of manifest and sources with JUnit 5, the other set of manifest and sources with JUnit 6. |
7af4a00 to
a9767d3
Compare
|
Seems like we don't have a build with the latest JUnit 6 changes in JDT UI. We'll have to wait more here. I also see problems with #2113, maybe it will be best to include the new tests here. Similar to the JDT UI PR/tests. |
Yes, tonight's I-build failed but I have already prepared a fix and I'm currently in the process of verifying it.
I think that makes sense to have the new functionality tested immediately. This also makes it simpler to review and test this change. |
|
Looks like JUnit 4 vintage test plug-in launches are broken with changes here. Among other problems I see in tests. It might be good to look into disabling the JUnit 6 choice for plug-in test launches, in case we don't manage to fix everything that doesn't work until the end of the next week. |
Fixes: #2108