Skip to content

Conversation

@rubenporras
Copy link
Contributor

No description provided.

@rubenporras
Copy link
Contributor Author

I do not know why LSP4E does not build with a target upgraded to Eclipse 4.38 and I have been looking at this already for a couple of hours. Any help would be appreciated.

</location>
<location type="InstallableUnit" includeConfigurePhase="true" includeMode="planner" includeSource="true">
<repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.37.0"/>
<repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.38.0"/>
Copy link
Member

@sebthom sebthom Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebthom
Copy link
Member

sebthom commented Nov 26, 2025

I am not a big fan of building only against Eclipse integration builds. If we do this, we end up releasing LSP4E versions that were never tested with the actual released Eclipse version. This can lead to unexpected errors and incompatibilities.

In TM4E, we use a matrix build that tests against three versions: the oldest supported Eclipse version, the latest stable Eclipse version, and the current Eclipse staging release. I know some people think this is too much work, but I disagree.

At the very least, we should test and develop against both the latest stable Eclipse version and the latest integration build.

@rubenporras
Copy link
Contributor Author

rubenporras commented Nov 27, 2025

@sebthom , I think this is the same as using latest, which is what we had in the repo until yesterday when I needed to switch it to have working builds.

I have now updated the PR to use latest, and it is failing again. I guess it has to do with the Junit 5 vs Junit 6 changes in eclipse 4.38 (see https://eclipse.dev/eclipse/markdown/?f=news/4.38/pde.md). I think we are seeing the item "Launch is executed by runs no tests or reports that no tests were found". @FlorianKroiss, could you take a look?

@rubenporras
Copy link
Contributor Author

I am not a big fan of building only against Eclipse integration builds. If we do this, we end up releasing LSP4E versions that were never tested with the actual released Eclipse version. This can lead to unexpected errors and incompatibilities.

I agree, this was just me testing different combinations.

@FlorianKroiss
Copy link
Contributor

I can take a look, but probably not before next week

@rubenporras
Copy link
Contributor Author

That is great, don't worry, there is no rush.

@sebthom
Copy link
Member

sebthom commented Nov 27, 2025

I had a same/similar issue in TM4E and solved it by setting <providerHint>junit5</providerHint>

				<plugin>
					<groupId>org.eclipse.tycho</groupId>
					<artifactId>tycho-surefire-plugin</artifactId>
					<version>${tycho-version}</version>
					<configuration>
						<!-- https://wiki.eclipse.org/Tycho/FAQ#How_to_use_SWTBot_or_some_UI_tool_for_testing.3F -->
						<useUIHarness>true</useUIHarness>
						<useUIThread>true</useUIThread>
						<argLine>-Xms512m -Xmx512m -Dfile.encoding=${project.build.sourceEncoding} ${tycho-surefire-plugin.vmargs}</argLine>
						<providerHint>junit5</providerHint>
					</configuration>
				</plugin>

@rubenporras rubenporras merged commit 7ef482c into eclipse-lsp4e:main Nov 28, 2025
12 checks passed
@rubenporras rubenporras deleted the upgrade_target_file branch November 28, 2025 09:42
@rubenporras
Copy link
Contributor Author

I had a same/similar issue in TM4E and solved it by setting <providerHint>junit5</providerHint>

Thanks a lot, that was the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants