-
Notifications
You must be signed in to change notification settings - Fork 66
build: upgrade target file to use Eclipse 4.38 #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade target file to use Eclipse 4.38 #1428
Conversation
target-platforms/target-platform-latest/target-platform-latest.target
Outdated
Show resolved
Hide resolved
e2802fa to
179c760
Compare
|
I do not know why LSP4E does not build with a target upgraded to Eclipse 4.38 and I have been looking at this already for a couple of hours. Any help would be appreciated. |
| </location> | ||
| <location type="InstallableUnit" includeConfigurePhase="true" includeMode="planner" includeSource="true"> | ||
| <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.37.0"/> | ||
| <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/release/4.38.0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I am not a big fan of building only against Eclipse integration builds. If we do this, we end up releasing LSP4E versions that were never tested with the actual released Eclipse version. This can lead to unexpected errors and incompatibilities. In TM4E, we use a matrix build that tests against three versions: the oldest supported Eclipse version, the latest stable Eclipse version, and the current Eclipse staging release. I know some people think this is too much work, but I disagree. At the very least, we should test and develop against both the latest stable Eclipse version and the latest integration build. |
179c760 to
ffa04cf
Compare
|
@sebthom , I think this is the same as using latest, which is what we had in the repo until yesterday when I needed to switch it to have working builds. I have now updated the PR to use latest, and it is failing again. I guess it has to do with the Junit 5 vs Junit 6 changes in eclipse 4.38 (see https://eclipse.dev/eclipse/markdown/?f=news/4.38/pde.md). I think we are seeing the item "Launch is executed by runs no tests or reports that no tests were found". @FlorianKroiss, could you take a look? |
I agree, this was just me testing different combinations. |
|
I can take a look, but probably not before next week |
|
That is great, don't worry, there is no rush. |
|
I had a same/similar issue in TM4E and solved it by setting <plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-surefire-plugin</artifactId>
<version>${tycho-version}</version>
<configuration>
<!-- https://wiki.eclipse.org/Tycho/FAQ#How_to_use_SWTBot_or_some_UI_tool_for_testing.3F -->
<useUIHarness>true</useUIHarness>
<useUIThread>true</useUIThread>
<argLine>-Xms512m -Xmx512m -Dfile.encoding=${project.build.sourceEncoding} ${tycho-surefire-plugin.vmargs}</argLine>
<providerHint>junit5</providerHint>
</configuration>
</plugin> |
ffa04cf to
2cee6fc
Compare
Thanks a lot, that was the solution. |
No description provided.