Restore build shortcut

[kwin]

This closes #1618

[laeubi]

As mentioned already on other places, simply adding the short-cut again is not what we want:

• #1956

instead one should register a keybinding with whatever shortcut we like.

[kwin]

is not what we want:

Well, this seem to be mostly you.

instead one should register a keybinding with whatever shortcut we like.

To what action? The action allowing to select a Maven execution is perfectly fine for the shortcut and desired by most customers.

[github-actions]

Test Results

  216 files   - 108    216 suites   - 108   49m 50s ⏱️ - 24m 3s
  690 tests ±  0    668 ✅ ±  0  21 💤 ± 0  0 ❌ ±0  1 🔥 ±0 
1 380 runs   - 690  1 337 ✅  - 669  42 💤  - 21  0 ❌ ±0  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit 212eb48. ± Comparison against base commit cccacb0.

[laeubi]

To what action

Running the (most recent?) maven launch for the currently active project. You do not need a Launch Shortcut for that, like you can pres CTRL+SHIFT+T to open a type search does not need a launch shortcut.

Or I can press SHIFT+CTRL+ALT+T to open a new Terminal session, also not needing any launch shortcuts, so there are many ways actions are triggered without needing it to have an superfluous launch shortcut in the menu.

As an alternative one could look how launch shortcuts are implemented and look if we can just have an option to hide it but retain the key-binding.

and desired by most customers.

What customers? Customers are people that pay for something...

[laeubi]

@kwin I let copilote generate a skeleton here

• Fix Maven build shortcut (Alt+Shift+X+M) not working since Eclipse 2023-09 #2049

it usually requires some review/testing and adjustments (e.g. we do only want to handle the usual run command), still it might act as a starting point.

[kufnerg]

I agree that one should aim for a nice, clean and maintainable and what not solution. At the same time, I think it's more important to care about making sure users actually get value and have a good experience even if they are not paying customers. One would expect that if you remove a dirty solution you replace it with a better one, but this working solution was simply deleted leaving many people frustrated with eclipe once again. If users dont have a smooth experience and love the product, that’s not a win! Right now, the biggest risk isn’t technical debt — it’s losing users because their experience feels rough.

[laeubi]

Everyone is welcome to contribute, the linked solution seems quite doable, so you probably like to pick it up, polish it a bit we merge it and you make the users happy including you.

[claudioweiler]

Thanks for this PR restoring useful behavior!

@laeubi

"simply adding the short-cut again is not what we want"

Well, this is what I want, and I was workarounding this for each installation I made. And I think that it's was requested on #1618 and #1956.

Take a look at your PR #2049 and I think its a new behavior that could be good also, but, please, do not remove this restored behavior.

Re-runs the most recent Maven launch: could it be just a "Re-runs the most recent launch"? But for Maven, this is done by "Maven build..." that have no shortcut assigned. But, I also run multiple goals in same project, depending on project state.

Supports goal-specific shortcuts: This is good for default Maven goals, but I really like to use custom goals (run configurations).

[Omega1001]

@laeubi I can only speak for my self, but just launching "the last Maven build of the project" is not gonna work for me.
Just Clicking the Launch button already does so BTW in most cases (rerun last build).

In case i have more then one launch config, i have so in case i need to run a build with some profiles active, so not even differing in goals.
In that case, the old behavior gave me a nice dialog that was maneuverable with arrow key and enter to swiftly select the build i want.

In any case, any new binding should trigger the still existing, but currently unusable action, rather than defining a new one.

I still dont relay see why this old behavior is perceived as "dirty" in the first place.
I still feel like listing all maven build in the popup is more trouble than its worth, also since it is pretty much permanently overlooked.
All it did was cost me lots of time explaining to our trainees over and over again, that clicking "Maven Build" will create a new launch config every time, which is all but obvious.

"If it aint broke, dont fix it"

+1 for this PR

[laeubi]

In that case, the old behavior gave me a nice dialog that was maneuverable with arrow key and enter to swiftly select the build i want.

Nothing prevents you from show that dialog with the proposed solution in #2049 that would maybe even make it simpler. Launching just the last was just a very first example if something else work better fine with that.

So fetch the PR, adjust it as you think it best fit, create a PR and we can merge it. If it happens before the end of November it will be part of the release (and before part of the snapshots).

I still dont relay see why this old behavior is perceived as "dirty" in the first place.

Because what we see in the poup in the first place is what you will see when you click the Maven build (+ you get the behavior from the ... one right below so it is confusing to do something else after you used it once), so it is redundant, clutters the UI, inconsistent and only a few items get Shortcuts so we want to keep that list short.

I still feel like listing all maven build in the popup is more trouble than its worth, also since it is pretty much permanently overlooked.

This feature is not provided by m2e but the Eclipse platform and many people like that... so everyone has different workflows and like different things.

All it did was cost me lots of time

Then you might want to invest some times here and implement a permanent and consistent solution... or wait unless someone else picks it up if it is not THAT important to you...

explaining to our trainees over and over again, that clicking "Maven Build" will create a new launch config every time, which is all but obvious.

Beside that the three dots consistently in Eclipse and other UIs indicate a new dialog opens, so one would hope not to need explain it to everyone again.

[laeubi]

Superseded by #2073