Skip to content

Conversation

@Omega1001
Copy link
Contributor

Reconnected the shortcut to an action that calls the previous code.
This is working without bringing the Button back, as Requested in #2048
Also closes #1618

Restores the previous behavior of the shortcut: (be reconnecting the old code)
If no maven launch configuration exists: Open the Create Dialog.
If exactly one configuration exists: Launch that configuration.
If more than one exists: Open a filterable/maneuverable Dialog to select which one you want.

@laeubi How's this?

@laeubi
Copy link
Member

laeubi commented Oct 25, 2025

@Omega1001 many thanks for looking into this, you need to sign the ECA so we can accept your contribution, but as all tests pass already it seems working fine apart from that!

@github-actions
Copy link

Test Results

  324 files  ±0    324 suites  ±0   1h 14m 28s ⏱️ + 2m 32s
  692 tests ±0    669 ✅  - 1  21 💤 ±0  1 ❌ +1  1 🔥 ±0 
2 076 runs  ±0  2 011 ✅  - 1  63 💤 ±0  1 ❌ +1  1 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 36daa83. ± Comparison against base commit 27eae6a.

@laeubi
Copy link
Member

laeubi commented Oct 25, 2025

Other errors are unrelated!

@Omega1001
Copy link
Contributor Author

@Omega1001 many thanks for looking into this, you need to sign the ECA so we can accept your contribution, but as all tests pass already it seems working fine apart from that!

Already did right after the push.
Github account is also linked.
Guess the update is a poll, so it should pick that up any time now.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, lets try!

@laeubi laeubi merged commit 091f04f into eclipse-m2e:main Oct 26, 2025
14 of 15 checks passed
@HannesWell HannesWell added this to the 2.10.0 milestone Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maven build shortcut not working

3 participants