Merged
Conversation
laeubi
approved these changes
May 6, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
Looks reasonable. Do you think it needs further enhancements? If not just adjust the Commit message and set this ready for review.
Workspaces.getWorkspace(IProject) now returns the correct bnd workspace for the 'cnf' project which is a 'magic' marker project name for a bnd workspace. Clicking on a cnf project now gives the same bnd workspace as clicking on a normal bnd project.
chrisrueger
force-pushed
the
bnd-workspace-improvements
branch
from
6771ada to
aa467a0
Compare
Contributor
Author
I think this is fine for now. Probably not the last change, but ok for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
The current change has the following effect:
If you click in a project called "cnf" (which is kind of a marker project name for a bnd workspace) then the correct Bnd Workspace is returned.
In the RepositoriesView this has the effect that the Bnd Workspace Repository and all other bnd repos are also shown if you click on "cnf" project.
Before this change clicking on a "cnf" project did not show any of the Bnd Workspace repositories (just the PDE Target Repo).