Fix PDEFormEditor.dispose() calling super.dispose() first#1964
Merged
iloveeclipse merged 1 commit intoeclipse-pde:masterfrom Sep 11, 2025
Merged
Fix PDEFormEditor.dispose() calling super.dispose() first#1964iloveeclipse merged 1 commit intoeclipse-pde:masterfrom
iloveeclipse merged 1 commit intoeclipse-pde:masterfrom
Conversation
Common pattern for init/dispose, setup/teardown is that on init, super is called first and on dispose last. This is always done this way to allow super class initialize whatever needed first and subclass work on that, and the dispose should always perform cleanup in the opposite direction. Otherwise super code might cleanup things that are still needed for the subclass to properly cleanup. Probably related to eclipse-pde#1963
Member
Author
|
The Linux github build hangs since hours probably trying to upload results, other (Jenkins) Linux build is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common pattern for init/dispose, setup/teardown is that on init, super is called first and on dispose last.
This is always done this way to allow super class initialize whatever needed first and subclass work on that, and the dispose should always perform cleanup in the opposite direction. Otherwise super code might cleanup things that are still needed for the subclass to properly cleanup.
Probably related to
#1963