Update pde.ui.tests test suite to JUnit5 by vogella · Pull Request #1998 · eclipse-pde/eclipse.pde

vogella · 2025-10-07T19:23:45Z

No description provided.

github-actions · 2025-10-07T19:57:05Z

Test Results

771 files +39 771 suites +39 1h 18m 37s ⏱️ + 26m 3s
3 609 tests - 1 3 557 ✅ ± 0 52 💤 - 1 0 ❌ ±0
10 827 runs - 3 10 670 ✅ ± 0 157 💤 - 3 0 ❌ ±0

Results for commit f7ef071. ± Comparison against base commit 01bf84c.

This pull request removes 672 and adds 671 tests. Note that renamed tests count towards both.

org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_importPackage
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeFragments
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeFragmentsProvidingPackages
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeNonTestFragments
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_includeOptional
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requireBundle
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requireBundle2
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requireDifferentVersions
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requiredCapability
org.eclipse.pde.core.tests.internal.DependencyManagerTest ‑ testFindRequirementsClosure_requirementsOfTransitivlyRequiredFragment
…

AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testAbsentHeader
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testChangeExistingActivator
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testGetActivator
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testHeaderLength
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testHeaderLengthWithWindowsDelimiter
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testHeaderOffset1
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testHeaderOffset2
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testPresentHeader
AllPDETests AllBundleModelTests BundleActivatorTestCase ‑ testSetActivator
AllPDETests AllBundleModelTests BundleClasspathTestCase ‑ testAbsentHeader
…

This pull request removes 25 skipped tests and adds 24 skipped tests. Note that renamed tests count towards both.

org.eclipse.pde.ui.tests.ee.ExportBundleTests ‑ Unknown test
org.eclipse.pde.ui.tests.imports.BaseImportTestCase ‑ testImportAnt[Import with source]
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testArgumentsInstallDirectory
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testArgumentsProfileContainer
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testDefaultTargetPlatform
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testDirectoryBundleContainer
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testEclipseHomeTargetPlatform
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testEclipseHomeTargetPlatformAndConfigurationArea
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testMissingVersionRestrictedDefaultTargetPlatform
org.eclipse.pde.ui.tests.target.LocalTargetDefinitionTests ‑ testVariableDirectoryBundleContainer
…

AllPDETests AllImportTests org.eclipse.pde.ui.tests.imports.BaseImportTestCase ‑ testImportAnt[Import with source]
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testArgumentsInstallDirectory
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testArgumentsProfileContainer
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testDefaultTargetPlatform
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testDirectoryBundleContainer
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testEclipseHomeTargetPlatform
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testEclipseHomeTargetPlatformAndConfigurationArea
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testMissingVersionRestrictedDefaultTargetPlatform
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testVariableDirectoryBundleContainer
AllPDETests AllTargetTests LocalTargetDefinitionTests ‑ testVersionRestrictedDefaultTargetPlatform
…

♻️ This comment has been updated with latest results.

HannesWell · 2025-10-09T06:08:38Z

ui/org.eclipse.pde.ui.tests/META-INF/MANIFEST.MF

 org.hamcrest,
 org.junit,
 org.junit.jupiter.api.function;version="5.8.1",
+ org.junit.jupiter.migrationsupport;version="[5.13.0,6.0.0)",


Thanks for this migration!
Is this import really necessary? I don't see it referenced directly or is it implicitly required?

I think it is so that JUnit5 can run older Junit tests.

I just learned yesterday that JUnit6 is already out. :-)

vogella · 2025-10-09T06:42:27Z

The failing tests are unrelated I assume but I will not commit until the build is green, or someone else links to the tracking issue / PR for the failing tests.

merks · 2025-10-09T07:00:12Z

My guess would be that some/all of these are related to the introduction of junit 6 in the target platform, e.g.,

Processing inclusion from feature org.eclipse.jdt: Bundle org.eclipse.jdt.junit5.runtime_1.1.400.v20250606-0904 failed to resolve.:
 Package uses conflict: Require-Bundle: junit-platform-suite-commons; bundle-version="1.8.1

/home/jenkins/agent/workspace/eclipse.pde_PR-1998/build/org.eclipse.pde.build.tests/target/sdk-product/p2/plugins/org.eclipse.pde.build_3.12.800.v20250515-0456/scripts/genericTargets.xml:112: Processing inclusion from feature org.eclipse.test: Bundle org.eclipse.core.tests.harness_3.17.400.v20250918-1202 failed to resolve.:
	Package uses conflict: Require-Bundle: junit-platform-suite-commons; bundle-version="0.0.0"
	Missing required plug-in org.eclipse.jdt.junit5.runtime_0.0.0

I'm not sure the details of this one:

	at org.eclipse.pde.ui.tests.launcher.AbstractLaunchTest.assertPluginMapsEquals(AbstractLaunchTest.java:138)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1095)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1080)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.assertGetMergedBundleMap(PluginBasedLaunchTest.java:1070)
	at org.eclipse.pde.ui.tests.launcher.PluginBasedLaunchTest.testGetMergedBundleMap_automaticAddedWorkspacePlugins_multiVersionPluginDisabledWithSpecificVersion(PluginBasedLaunchTest.java:459)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)

iloveeclipse · 2025-10-09T07:14:20Z

I fear we have either to revert eclipse-platform/eclipse.platform.releng.aggregator#3399 or do some tycho / maven fixes or configuration changes to make sure JUnit 6 is not used yet, even if it there on update site.

I saw also errors in platform UI which seem to be related: eclipse-platform/eclipse.platform.ui#3382 (comment)

@trancexpress , @laeubi : FYI.

merks · 2025-10-09T07:23:23Z

We won't move forward by moving backward. 😱 I think there are places that need upper bounds, particularly in JDT. If there were hundreds of failures, I'd be concerned, but there appear to be some handful of them...

First I will try to reproduce these problems in my SDK workspace where I can easily change anything in any project and in combination.

merks · 2025-10-09T08:00:46Z

@iloveeclipse

Looking at the generated report's information for junit-jupiter-api 6.0.0

https://download.eclipse.org/oomph/archive/reports/download.eclipse.org/eclipse/updates/4.38-I-builds/https___download.eclipse.org_eclipse_updates_4.38-I-builds_I20251008-1230/junit-jupiter-api_6.0.0.html

Use expand all (circled in red) we can see all the things that can bind to the capabilities provided by this IU.

For any of those you can open the dependency in a browser:

https://download.eclipse.org/oomph/archive/reports/download.eclipse.org/eclipse/updates/4.38-I-builds/https___download.eclipse.org_eclipse_updates_4.38-I-builds_I20251008-1230/org.eclipse.jdt.junit5.runtime_1.1.400.v20250606-0904.html#osgi.bundle;_junit-jupiter-api_5.4.0

So the JDT JUnit5 runtime has no upper bound.. That's just one example, it's pretty much across the board...

I've reproduced the PDE test failures locally via local Tycho build and will experiment a bit with "local workaround". I just wanted to keep you in the loop while I continue the investigations.

merks · 2025-10-09T08:12:49Z

FYI, "excluding" the junit-jupiter-api bundle passes the tests locally:

I'm now running a tycho build of all the PDE tests to see if they all pass.

merks · 2025-10-09T10:59:33Z

FYI, I'm down to these two failing tests.

Hopefully I'm close to the end now.

iloveeclipse · 2025-10-09T11:01:30Z

Hopefully I'm close to the end now.

Sorry, I hoped you could also take a look at platform.ui tests that most likely need same treatment :-)

merks · 2025-10-09T11:03:04Z

@iloveeclipse

Yes, it's on my multi-tasking, long todo list. (Today is also SimRel M1.)

akurtakov force-pushed the pde-ui-test-suite-migrated-to-junit5 branch from b7af523 to 03edcc0 Compare October 8, 2025 06:46

HannesWell reviewed Oct 9, 2025

View reviewed changes

Update pde.ui.tests test suite to JUnit5

f7ef071

merks force-pushed the pde-ui-test-suite-migrated-to-junit5 branch from 03edcc0 to f7ef071 Compare October 9, 2025 18:35

merks merged commit 46ec758 into eclipse-pde:master Oct 9, 2025
19 checks passed

iloveeclipse mentioned this pull request Oct 10, 2025

Equinox tests need fixes for JUnit 6 eclipse-equinox/p2#953

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update pde.ui.tests test suite to JUnit5#1998

Update pde.ui.tests test suite to JUnit5#1998
merks merged 1 commit intoeclipse-pde:masterfrom
vogella:pde-ui-test-suite-migrated-to-junit5

vogella commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

HannesWell Oct 9, 2025

Uh oh!

vogella Oct 9, 2025

Uh oh!

vogella commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

iloveeclipse commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

iloveeclipse commented Oct 9, 2025 •

edited

Loading

Uh oh!

merks commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vogella commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

HannesWell Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

vogella Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

vogella commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

iloveeclipse commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

merks commented Oct 9, 2025

Uh oh!

iloveeclipse commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

merks commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 7, 2025 •

edited

Loading

iloveeclipse commented Oct 9, 2025 •

edited

Loading