Only select compatible providers during collection of JUnit requirements#2037
Only select compatible providers during collection of JUnit requirements#2037laeubi wants to merge 2 commits intoeclipse-pde:masterfrom
Conversation
Currently PDE searches JUnit requirements primary by its id and adds them unconditionally. This does not work well when there are multiple options and versions. This now changes the selection process in the following way: 1) Select all required junit runtimes 2) Compute their dependencies and add them if required 3) Among all possible options select those engines and launchers that actually match a requirement in this set 4) if none of the matching are already selected, use the highest matching version
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
HannesWell
left a comment
There was a problem hiding this comment.
For this I also have to admit that I fail to the exact difference to #2013. At the same time this changes many things differently and will conflict with #2013.
And as the latter is hopfully is ready soon, my suggestion is to not delay #2013 further and keep the attribution with the author of it. If this contains changes that are eventually missing from the other PR, they still can be applied afterwards in this or a new PR.
...ipse.pde.launching/src/org/eclipse/pde/internal/launching/launcher/BundleLauncherHelper.java
Show resolved
Hide resolved
Test Results 571 files - 200 571 suites - 200 45m 42s ⏱️ - 24m 34s For more details on these failures, see this check. Results for commit d077f2f. ± Comparison against base commit 9851080. This pull request removes 85 tests. |
|
|
Changed to draft here, we should first complete the other PR before possibly improvements can be applied. |
Currently PDE searches JUnit requirements primary by its id and adds them unconditionally. This does not work well when there are multiple options and versions.
This now changes the selection process in the following way:
FYI @trancexpress