Skip to content

Copied JUnit 5 tests for JUnit 6 tests #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Copied JUnit 5 tests for JUnit 6 tests #2113

wants to merge 2 commits into from

Conversation

@trancexpress
Copy link
Contributor

@trancexpress trancexpress commented Nov 8, 2025

Fixes: #2111

@github-actions
Copy link

github-actions bot commented Nov 8, 2025 •
edited
Loading

Test Results

   774 files  + 3     774 suites  +3   54m 19s ⏱️ + 2m 40s
 3 648 tests +11   3 571 ✅  - 12   54 💤 ±0  23 ❌ +23 
10 878 runs  +33  10 646 ✅  - 36  163 💤 ±0  69 ❌ +69 

For more details on these failures, see this check.

Results for commit 11ed2bf. ± Comparison against base commit b00ef59.

♻️ This comment has been updated with latest results.

@trancexpress trancexpress force-pushed the gh2111 branch 2 times, most recently from 6510e29 to 4c2e9c1 Compare November 8, 2025 14:04
@trancexpress trancexpress mentioned this pull request Nov 8, 2025
Open
@trancexpress
Copy link
Contributor Author

trancexpress commented Nov 8, 2025 •
edited
Loading 

org.eclipse.core.runtime.CoreException: Launching failed. Bootstrap code cannot be found.
	at org.eclipse.pde.launching.JUnitLaunchConfigurationDelegate.abort(JUnitLaunchConfigurationDelegate.java:178)
	at org.eclipse.pde.launching.JUnitLaunchConfigurationDelegate.getClasspathAndModulepath(JUnitLaunchConfigurationDelegate.java:444)
	at org.eclipse.jdt.junit.launcher.JUnitLaunchConfigurationDelegate.getVMRunnerConfiguration(JUnitLaunchConfigurationDelegate.java:193)
	at org.eclipse.jdt.junit.launcher.JUnitLaunchConfigurationDelegate.launch(JUnitLaunchConfigurationDelegate.java:286)
	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:778)
	at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:689)
	at org.eclipse.debug.internal.ui.DebugUIPlugin.buildAndLaunch(DebugUIPlugin.java:1052)
	at org.eclipse.debug.ui.DebugUITools.buildAndLaunch(DebugUITools.java:1044)
	at org.eclipse.pde.junit.runtime.tests.TestExecutionUtil.launchAndWaitForTermination(TestExecutionUtil.java:129)
	at org.eclipse.pde.junit.runtime.tests.TestExecutionUtil.runTest(TestExecutionUtil.java:81)
	at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.executePackage(JUnitExecutionTest.java:114)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:93)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:520)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:748)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:443)
	at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:126)
	at org.eclipse.pde.internal.junit.runtime.PlatformUITestHarness.lambda$0(PlatformUITestHarness.java:45)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Testable.lambda$1(E4Testable.java:127)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:40)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:132)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:5083)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:4548)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1147)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1038)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:153)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:677)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:583)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:173)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:185)
	at org.eclipse.pde.internal.junit.runtime.NonUIThreadTestApplication.start(NonUIThreadTestApplication.java:58)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:615)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:563)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1415)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1387)

No idea what this is about.

I see it also when I just run org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest on master with:

Eclipse Platform
Version: 2025-12 (4.38)
Build id: I20251106-1910

@laeubi any idea why I see this error? When I debug, the problem is this code: org.eclipse.pde.internal.launching.launcher.LaunchArgumentsHelper.constructClasspath(ILaunchConfiguration)

	public static String[] constructClasspath(ILaunchConfiguration configuration) throws CoreException {
		double targetVersion = TargetPlatformHelper.getTargetVersion();
		String jarPath = targetVersion >= 3.3 ? getEquinoxStartupPath(IPDEBuildConstants.BUNDLE_EQUINOX_LAUNCHER) : getStartupJarPath();
		if (jarPath == null && targetVersion < 3.3) {
			jarPath = getEquinoxStartupPath("org.eclipse.core.launcher"); //$NON-NLS-1$
		}
		if (jarPath == null) {
			return null; // <------ code returns here
		}

Any idea what I'm missing in my workspace? I'm running the test as a JUnit 5 plug-in test with latest master.

@trancexpress
Copy link
Contributor Author

trancexpress commented Nov 8, 2025 •
edited
Loading

Fails I see when running locally, from command line:

Failures: 
  JUnit5SuiteExecutionTest.executePackage:68 test completed with Undefined
  JUnit5SuiteExecutionTest.executeProject:75 test completed with Undefined
  JUnit5SuiteExecutionTest.executeSuite:53 test completed with Undefined
  JUnitExecutionTest.executeMethod:134 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executeMethod:134 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executeMethod:134 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executeMethod:134 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executeMethod:134 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executePackage:116 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executePackage:116 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executePackage:116 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executePackage:116 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executePackage:116 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executeProject:124 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executeProject:124 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executeProject:124 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executeProject:124 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executeProject:124 
Expected size: 2 but was: 0 in:
[]
  JUnitExecutionTest.executeType:108->assertSuccessful:144 test completed with Error
  JUnitExecutionTest.executeType:108->assertSuccessful:144 test completed with Error
  JUnitExecutionTest.executeType:107 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executeType:107 
Expected size: 1 but was: 0 in:
[]
  JUnitExecutionTest.executeType:107 
Expected size: 1 but was: 0 in:
[]

Tests run: 46, Failures: 23, Errors: 0, Skipped: 0

There are also JUnit 4 fails, I'm not sure why:

org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.executeType[JUnit4 (JUnitPlatform) Fragment] -- Time elapsed: 0.726 s <<< FAILURE!
java.lang.AssertionError: test completed with Error
        at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.assertSuccessful(JUnitExecutionTest.java:144)
        at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.executeType(JUnitExecutionTest.java:108)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.eclipse.pde.ui.tests.runtime.TestUtils$1.evaluate(TestUtils.java:267)
        Suppressed: java.lang.AssertionError: FailureTrace of TestCase: verification.tests.junit4.platform.fragment.Test1.initializationError : Completed - Error:

org.junit.platform.commons.PreconditionViolationException: Cannot create Launcher without at least one TestEngine; consider adding an engine implementation JAR to the classpath
        at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:313)
        at org.junit.platform.launcher.core.DefaultLauncher.<init>(DefaultLauncher.java:59)
        at org.junit.platform.launcher.core.LauncherFactory.createDefaultLauncher(LauncherFactory.java:141)
        at org.junit.platform.launcher.core.LauncherFactory.lambda$create$2(LauncherFactory.java:132)
        at org.junit.platform.launcher.core.DefaultLauncherSession.lambda$new$0(DefaultLauncherSession.java:66)
        at org.junit.platform.launcher.core.ClasspathAlignmentCheckingLauncherInterceptor.intercept(ClasspathAlignmentCheckingLauncherInterceptor.java:25)
        at org.junit.platform.launcher.core.DefaultLauncherSession.<init>(DefaultLauncherSession.java:66)
        at org.junit.platform.launcher.core.SessionPerRequestLauncher.createSession(SessionPerRequestLauncher.java:78)
        at org.junit.platform.launcher.core.SessionPerRequestLauncher.discover(SessionPerRequestLauncher.java:58)
        at org.junit.platform.runner.JUnitPlatform.generateTestTree(JUnitPlatform.java:159)
        at org.junit.platform.runner.JUnitPlatform.<init>(JUnitPlatform.java:145)
        at org.junit.platform.runner.JUnitPlatform.<init>(JUnitPlatform.java:138)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
        at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
        at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:104)
        at org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:86)
        at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:70)
        at org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:37)
        at org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:70)
        at org.junit.internal.requests.ClassRequest.createRunner(ClassRequest.java:28)
        at org.junit.internal.requests.MemoizingRequest.getRunner(MemoizingRequest.java:19)
        at org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.createUnfilteredTest(JUnit4TestLoader.java:90)
        at org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.createTest(JUnit4TestLoader.java:76)
        at org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.loadTests(JUnit4TestLoader.java:49)
        at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:504)
        at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:748)
        at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:443)
        at org.eclipse.pde.internal.junit.runtime.RemotePluginTestRunner.main(RemotePluginTestRunner.java:126)
        at org.eclipse.pde.internal.junit.runtime.CoreTestApplication.start(CoreTestApplication.java:28)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:219)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:149)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:115)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:467)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:298)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:569)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:615)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:563)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1415)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1387)


                at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.addFailureTraces(JUnitExecutionTest.java:154)
                at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.addFailureTraces(JUnitExecutionTest.java:159)
                at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.addFailureTraces(JUnitExecutionTest.java:159)
                at org.eclipse.pde.junit.runtime.tests.JUnitExecutionTest.assertSuccessful(JUnitExecutionTest.java:145)
                ... 3 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests for running JUnit 6 plug-in tests

1 participant

@trancexpress