Fix view_menu #147
Fix view_menu #147
Conversation
There was a problem hiding this comment.
The image looks good in the sense that it's similar/equal to the existing one.
I see the issue with the SVG I proposed in eclipse-platform/eclipse.platform.ui#2995 which leads to "squarely-looking" circles due to the circles being aligned with the grid. Reason for me to do so was that it produces sharper results. See that the existing icon is more blurry than the one I proposed. On the top, you see my SVG, at the bottom, you see yours:
I agree that we should better stick to the existing look and feel.
|
@BeckerWdf so you agree that we should take the icon that Sebastian proposed, as it conforms to the existing one (even though it looks a bit blurry when rendered), right? |
No. I think we should go with the "sharp" one. Or does this version have other "problems"? |
|
Just checked your SVG. Based on the current PNG it's correct. But to improve sharpness the radius of circles should be an integer multiple of 1 (not 4,5 px but either 4 px or 5 px). |
|
Yes, agreed. After looking at them a bit in the IDE, I think we should take the opportunity to clean this up. Your sharper one (even though it looks slightly square) looks much better next to the angular-shaped minimize and maximize buttons.
I think 0.7 is too much: The following is a 200% screenshot. First circle ~0.5, second ~0.6, third ~0.7. I'd say the current stroke width (~0.5) is perfect. |
There were several issues with the view_menu icon: - The checked in SVG files were not matching the PNG files which have been used so far. - The disabled PNGs were not actually disabled, but copies of the enabled ones. - A @2x.png icon was still the old chevron icon. Fix: - Use SVG file from eclipse-platform/eclipse.platform.ui#2995, clean up metadata and exactly align on pixel boundaries and (half) integer stroke width. - Delete disabled SVG files and let the renderer derive the disabled PNG files. - Re-render everything to PNG.
view_menu.svg was the wrong svg file, not matching the .pngs. Follow-up on eclipse-platform#2925. Uses the updated icons taken from eclipse-platform/eclipse.platform.images#147
There was a problem hiding this comment.
Great, thank you! Tested the latest proposal and found it really convincing in eclipse-platform/eclipse.platform.ui#2994 (review)
view_menu.svg was the wrong svg file, not matching the .pngs. Follow-up on #2925. Uses the updated icons taken from eclipse-platform/eclipse.platform.images#147
There were several issues with the view_menu icon:
Fix: