Correct SVG icon for showing menu in part stacks and shared images #2995
Conversation
The SVG version of the icon for showing the menu in part stacks erroneously contained the "thin" version of that icon, showing an error instead of three dots. In addition, the shared image version of that icon contained the three dots shifted to the bottom right and smaller than intended. This change replaces both SVG version with the same icon containing the correct three-dot-version of the view_menu icon.
|
I don't see this particular version of |
Yes, I took the original |
|
Note: I am not an expert in creating SVGs, so feel free to check/update the proposed SVG. I tried to uniformly align the circles with the 16x16 grid to ensure that rasterization produces as sharp as possible results. |
Test Results 1 824 files ±0 1 824 suites ±0 1h 39m 56s ⏱️ - 2m 37s For more details on these failures, see this check. Results for commit 0c3dc18. ± Comparison against base commit 710a26a. |
Hmm, it does look different than the old .png. It's almost like it's squares, not circles. |
|
That icon was quite the mess: Let's start at the source: I tried to re-create the PNGs that have been used over the last years as closely as possible in eclipse-platform/eclipse.platform.images#147 and re-rendered everything. |
|
Can I help here or did you sort this out in the meantime? |
There were several issues with the view_menu icon: - The checked in SVG files were not matching the PNG files which have been used so far. - The disabled PNGs were not actually disabled, but copies of the enabled ones. - A @2x.png icon was still the old chevron icon. Fix: - Use SVG file from eclipse-platform/eclipse.platform.ui#2995, clean up metadata and exactly align on pixel boundaries and (half) integer stroke width. - Delete disabled SVG files and let the renderer derive the disabled PNG files. - Re-render everything to PNG.
There were several issues with the view_menu icon: - The checked in SVG files were not matching the PNG files which have been used so far. - The disabled PNGs were not actually disabled, but copies of the enabled ones. - A @2x.png icon was still the old chevron icon. Fix: - Use SVG file from eclipse-platform/eclipse.platform.ui#2995, clean up metadata and exactly align on pixel boundaries and (half) integer stroke width. - Delete disabled SVG files and let the renderer derive the disabled PNG files. - Re-render everything to PNG.
|
Closing in favor of #2994. |
The SVG version of the icon for showing the menu in part stacks erroneously contained the "thin" version of that icon, showing an error instead of three dots. In addition, the shared image version of that icon contained the three dots shifted to the bottom right and smaller than intended.
This change replaces both SVG version with the same icon containing the correct three-dot-version of the view_menu icon.
Before
After