[Releng] Rename publishToMaven job to deployToMaven and derive deployment type from sourceRepository
#3182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
maven-deploy-enhancements
branch
2 times, most recently
from
c9070c1 to
198ca03
Compare
This allows to remove the explicit 'snapshotOrRelease' parameter and simplifies invoking the job. The deployment type is derived from the sourceRepository URL. But as a safeguard the user is instead asked for confirmation if a 'release' deployment is detected.
to better match the Maven terminology.
HannesWell
force-pushed
the
maven-deploy-enhancements
branch
from
198ca03 to
5766a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains to separate but still loosely related changes of the Maven deployment job:
sourceRepositoryto remove thesnapshotOrReleaseparameter.publishToMavenjob todeployToMavento better match the Maven terminology.As a safeguard the user is asked for confirmation on the Console if a
releasedeployment is determined.@merks, @MohananRahul and @elsazac or anybody else, do you have objections?