Sporadically failing Browser Tests logging for Edge Browser #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fedejeanne
previously requested changes
May 27, 2025
amartya4256
force-pushed
the
amartya4256/add_logging_to_browser_test
branch
from
d35c5c5 to
169cbca
Compare
HeikoKlare
reviewed
Jun 5, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The added information might be useful for debugging the sporadically failing tests and it's only printed if the test fails. I have some minor comments.
....swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
Outdated
Show resolved
Hide resolved
....swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_browser_Browser.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
amartya4256/add_logging_to_browser_test
branch
2 times, most recently
from
c230e26 to
33d8a62
Compare
This commit adds relevant loggings for debugging purposes to the Browser tests which sporadically fail for Edge Browser. contributes to eclipse-platform#2098, eclipse-platform#2113 and eclipse-platform#2063
HeikoKlare
force-pushed
the
amartya4256/add_logging_to_browser_test
branch
from
33d8a62 to
18babdf
Compare
HeikoKlare
approved these changes
Jun 6, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you! Looks fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds relevant loggings for debugging purposes to the Browser tests which sporadically fail for Edge Browser.
contributes to #2098, #2113 and #2063