[Build] Use Eclipse Platform Bot to commit built SWT binaries #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
use-platform-bot
branch
from
ea8ad32 to
219f464
Compare
Member
|
Looks good to me. |
Contributor
Contributor
|
Looks good to me as well. |
Use the Eclipse Platform Bot to commit built SWT binaries with its correct email as recorded in the EF-API (https://api.eclipse.org/bots ) and that is also associated with it's Github account. Before the Eclipse Releng Bot was used for that, but with an incorrect email. Fixes - https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6227
HannesWell
force-pushed
the
use-platform-bot
branch
from
219f464 to
6be0853
Compare
Member
Author
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
Eclipse Platform Botto commit built SWT binaries with its correct email as recorded in the EF-API (https://api.eclipse.org/bots ) and that is also associated with it's Github account. Before theEclipse Releng Botwas used for that, but with an incorrect email.Not it's the same bot that is also used for version increments:
eclipse.platform.swt/.github/workflows/pr-checks.yml
Lines 20 to 21 in 5115799
I think that is more suitable than using the Releng Bot (even with a fixed mail).
Fixes
@akurtakov, @iloveeclipse, @HeikoKlare any objection?