Skip to content

[Win32] Fix wrong width and height in Sash with SWT.SMOOTH when dragging #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

[Win32] Fix wrong width and height in Sash with SWT.SMOOTH when dragging #2333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Sash.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,19 +320,21 @@ LRESULT WM_LBUTTONUP (long wParam, long lParam) {
dragging = false;
RECT rect = new RECT ();
OS.GetWindowRect (handle, rect);
int width = rect.right - rect.left;
int height = rect.bottom - rect.top;
int widthInPixels = rect.right - rect.left;
int heightInPixels = rect.bottom - rect.top;

/* The event must be sent because doit flag is used */
Event event = new Event ();
event.setBounds(Win32DPIUtils.pixelToPoint(new Rectangle(lastX, lastY, width, height), getZoom()));
drawBand (lastX, lastY, width, height);
event.setBounds(Win32DPIUtils.pixelToPoint(new Rectangle(lastX, lastY, widthInPixels, heightInPixels), getZoom()));
drawBand (lastX, lastY, widthInPixels, heightInPixels);
sendSelectionEvent (SWT.Selection, event, true);
if (isDisposed ()) return result;
Rectangle bounds = event.getBounds();
if (event.doit) {
if ((style & SWT.SMOOTH) != 0) {
setBounds (bounds.x, bounds.y, width, height);
int xInPixels = Win32DPIUtils.pointToPixel(bounds.x, getZoom());
int yInPixels = Win32DPIUtils.pointToPixel(bounds.y, getZoom());
setBoundsInPixels (xInPixels, yInPixels, widthInPixels, heightInPixels);
// widget could be disposed at this point
}
}
Expand Down
Loading