[Win32] Fix wrong width and height in Sash with SWT.SMOOTH when dragging #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 546 files ±0 546 suites ±0 30m 10s ⏱️ +27s Results for commit 92e81bf. ± Comparison against base commit f0afb7f. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
Contributor
Author
|
@ShadelessFox can you test whether this change fixes the issue that you reproted? |
Contributor
|
I confirm that these changes fix the issue :^) |
When dragging a Sash with the SWT.SMOOTH, the width and height of the sash are erroneously scaled up by the current zoom. It is caused by a recent change which replaced a setBoundsInPixels with a setBounds call still using the same pixel-based width and height values. This change adapts the according call to consistently use pixel-based values passed to the setBoundsInPixels method again. Fixes eclipse-platform#2329
amartya4256
approved these changes
Jul 22, 2025
Contributor
amartya4256
left a comment
amartya4256
left a comment
There was a problem hiding this comment.
Fair! Since, the width and the height obtained are in Pixels, we should call setBoundsInPixels for that scale. Hence, approved.
arunjose696
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dragging a Sash with the SWT.SMOOTH, the width and height of the sash are erroneously scaled up by the current zoom. It is caused by a recent change which replaced a setBoundsInPixels with a setBounds call still using the same pixel-based width and height values.
This change adapts the according call to consistently use pixel-based values passed to the setBoundsInPixels method again.
Fixes #2329