- 
                Notifications
    You must be signed in to change notification settings 
- Fork 185
Control.gtk_motion_notify_event: format to understand it #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Control.gtk_motion_notify_event: format to understand it #2572
Conversation
| Test Results  111 files   -  7    111 suites   - 7   11m 29s ⏱️ +22s For more details on these errors, see this check. Results for commit d383295. ± Comparison against base commit 48e5878. This pull request removes 56 and adds 1 tests. Note that renamed tests count towards both. | 
| boolean [] consume = new boolean [1]; | ||
| if (dragDetect ((int) eventX[0], (int) eventY[0], true, true, consume)) { | ||
| dragging = true; | ||
| if (consume [0]) result = 1; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this line deleted on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because result is not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please remove "result" variable entirely in this case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to do the requested change so this one can be merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- remove empty `else` branch - remove unused `result`
to easier understand it
d383295    to
    d8dfeb3      
    Compare
  
    
The indentation was screwed up, so it was hard to understand the logic.
I also removed the unused assignment to
resultand the emptyelse-branch.