Skip to content

Control.gtk_motion_notify_event: format to understand it #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −12
Open

Control.gtk_motion_notify_event: format to understand it #2572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6fcbde
Control.gtk_motion_notify_event: remove unused code
Oct 31, 2025
d8dfeb3
Control.gtk_motion_notify_event: fix formatting
Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4147,8 +4147,6 @@ void gtk4_motion_event(long controller, double x, double y, long event) {

@Override
long gtk_motion_notify_event (long widget, long event) {
int result;

double[] eventX = new double[1];
double[] eventY = new double[1];
GDK.gdk_event_get_coords(event, eventX, eventY);
Expand All @@ -4160,13 +4158,11 @@ long gtk_motion_notify_event (long widget, long event) {
// See comment in #dragDetect()
if ((dragDetectionQueue != null) && OS.isWayland()) {
boolean dragging = false;
if ((state & DRAG_DETECT) != 0 && wantDragDropDetection ()) {
boolean [] consume = new boolean [1];
if (dragDetect ((int) eventX[0], (int) eventY[0], true, true, consume)) {
dragging = true;
if (consume [0]) result = 1;
if (isDisposed ()) return 1;
} else {
if ((state & DRAG_DETECT) != 0 && wantDragDropDetection()) {
boolean[] consume = new boolean[1];
if (dragDetect((int)eventX[0], (int)eventY[0], true, true, consume)) {
dragging = true;
if (isDisposed()) return 1;
}
}
if (dragging) {
Expand All @@ -4186,7 +4182,7 @@ long gtk_motion_notify_event (long widget, long event) {
GDK.gdk_event_get_state(event, eventState);
}

if (sendDragEvent (eventButton[0], eventState[0], scaledEvent.x, scaledEvent.y, false)){
if (sendDragEvent (eventButton[0], eventState[0], scaledEvent.x, scaledEvent.y, false)) {
return 1;
}
}
Expand Down Expand Up @@ -4239,8 +4235,8 @@ long gtk_motion_notify_event (long widget, long event) {
}
}

result = sendMouseEvent(SWT.MouseMove, 0, time, x, y, isHint, state[0]) ? 0 : 1;
return result;
return sendMouseEvent(SWT.MouseMove, 0, time, x, y, isHint, state[0])
? 0 : 1;
}

@Override
Expand Down
Loading