Skip to content

Control.gtk_motion_notify_event: format to understand it #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Control.gtk_motion_notify_event: format to understand it #2572

wants to merge 2 commits into from

Conversation

@tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Oct 1, 2025

The indentation was screwed up, so it was hard to understand the logic.

I also removed the unused assignment to result and the empty else-branch.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025 •
edited
Loading

Test Results

  108 files   -  7    108 suites   - 7   12m 39s ⏱️ + 1m 38s
4 557 tests  - 56  4 525 ✅  - 72  13 💤  - 3  6 ❌ +6  13 🔥 +13 
  256 runs   - 56    256 ✅  - 53   0 💤  - 3  0 ❌ ±0 

For more details on these failures and errors, see this check.

Results for commit d8dfeb3. ± Comparison against base commit 4722846.

This pull request removes 56 tests. 
AllWin32Tests ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
AllWin32Tests ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
AllWin32Tests ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromCopiedImage
AllWin32Tests ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
AllWin32Tests TestTreeColumn ‑ test_ColumnOrder
…

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Contributor

@tmssngr the failed test on Windows is something new I introduced and the Windows failure is being investigated in #2568

Thomas Singer added 2 commits October 31, 2025 10:30
Control.gtk_motion_notify_event: remove unused code
f6fcbde 
- remove empty `else` branch
- remove unused `result`
Control.gtk_motion_notify_event: fix formatting
d8dfeb3 
to easier understand it
@tmssngr tmssngr force-pushed the format-Control.gtk_motion_notify_event branch from d383295 to d8dfeb3 Compare October 31, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akurtakov akurtakov akurtakov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tmssngr @jonahgraham @akurtakov