[GTK] send a g_critical if SWT calls a function that failed to load #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a library function fails to load, the JNI wrapper returns 0 (or similar) for that function. There is no way to tell from the Java side that the function failed to work. This change prints a g_critical error so that it is somewhat detectable, at least by SWT devs, that something has gone wrong in the implementation. Ideally I would throw an unsatisfied link exception or something similar, but that would change a potentially minor error into a show stopper. For example, if we threw an exception the simple memory leak fixed in eclipse-platform#2704 would have been throwing an exception all this time instead of silently not freeing the memory. This change is especially useful as we work on GTK4 which includes lots of breaking API changes in webkit.
|
Rebased on master for the sake of unbreaking verification build. |
Test Results 118 files ±0 118 suites ±0 17m 2s ⏱️ +49s For more details on these failures, see this check. Results for commit 6bea783. ± Comparison against base commit 27f1d6c. |
Oops I forgot to rebase this one. Thank you for handling that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a library function fails to load, the JNI wrapper returns 0 (or similar) for that function. There is no way to tell from the Java side that the function failed to work.
This change prints a g_critical error so that it is somewhat detectable, at least by SWT devs, that something has gone wrong in the implementation.
Ideally I would throw an unsatisfied link exception or something similar, but that would change a potentially minor error into a show stopper. For example, if we threw an exception the simple memory leak fixed in #2704 would have been throwing an exception all this time instead of silently not freeing the memory.
This change is especially useful as we work on GTK4 which includes lots of breaking API changes in webkit.