Restore ability to filter views by category #2579

ptziegler · 2024-12-03T17:40:38Z

The ability to sort by categories was previously possible, but broke as part of 7275893. This seems to be unintentional, given that the linked bug [1] is about exposing the FilteredTree and likely a result of streamlining the implementation.

[1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=74795

Fixes #2576

ptziegler · 2024-12-03T17:41:03Z

#2576

recording.webm

eclipse-platform-bot · 2024-12-03T17:45:28Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 7a03c945b89125943d437d42154badd2d23a52bf Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 6 Dec 2024 22:00:21 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
index c15044ab33..ce84f6bee7 100644
--- a/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.swt;singleton:=true
-Bundle-Version: 0.17.600.qualifier
+Bundle-Version: 0.17.700.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

github-actions · 2024-12-03T18:56:52Z

Test Results

0 tests ±0 0 ✅ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 242001c. ± Comparison against base commit 7adb4ef.

♻️ This comment has been updated with latest results.

vogella · 2024-12-04T07:20:18Z

Nice and easy fix. Thanks @ptziegler. Looks like we have issues with either Tycho (cc @laeubi) or JDT (cc @iloveeclipse):

https://github.com/eclipse-platform/eclipse.platform.ui/actions/runs/12154551527/job/33894491261?pr=2579#step:7:75

Could not find artifact org.eclipse.jdt:ecj:jar:3.40.100-SNAPSHOT in eclipse-snapshots (https://repo.eclipse.org/content/repositories/eclipse-snapshots/)

ptziegler · 2024-12-06T17:00:05Z

16:11:28.503 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.jface.text: There are API errors:
16:11:28.503 [ERROR] META-INF/MANIFEST.MF:5 The minor version should be incremented in version 3.26.100, since new APIs have been added since version 3.26.0

The bundles org.eclipse.jface.text as well as org.eclipse.jface.text.tests haven't been touched by this PR... I assume that this is a result of #2051?

HannesWell

Thank you Patrick for this one.
I noticed this recently as well and it's annoying that this is currently not working.

The change looks good. But the method could be clean-ed up.
Are you interested in doing it in this PR (maybe as a second or first commit) or in a follow-up?

...e4.ui.workbench.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewPatternFilter.java

HannesWell · 2024-12-06T17:54:32Z

16:11:28.503 [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.jface.text: There are API errors:
16:11:28.503 [ERROR] META-INF/MANIFEST.MF:5 The minor version should be incremented in version 3.26.100, since new APIs have been added since version 3.26.0

The bundles org.eclipse.jface.text as well as org.eclipse.jface.text.tests haven't been touched by this PR... I assume that this is a result of #2051?

Looks like yes. I have created #2598, to fix that soon.

ptziegler · 2024-12-06T18:03:26Z

Are you interested in doing it in this PR (maybe as a second or first commit) or in a follow-up?

I don't think a second PR for such a small change is really needed.

HannesWell

Are you interested in doing it in this PR (maybe as a second or first commit) or in a follow-up?

I don't think a second PR for such a small change is really needed.

Agree, just wanted to give you multiple options. :)

Thanks for applying the requested changes so quickly, but I think we had a slight miscommunication and it was a bit too much.

...e4.ui.workbench.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewPatternFilter.java

The ability to sort by categories was previously possible, but broke as part of 7275893. This seems to be unintentional, given that the linked bug [1] is about exposing the FilteredTree and likely a result of streamlining the implementation. [1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=74795 Fixes eclipse-platform#2576

HannesWell

Thank you for this fix. Nice work!

I just pushed a tiny update to remove the version increment from again from your commit, so that the automated version increment workflow can do it in a separate commit.
If you have learned to anticipate version increments in the past, with that automation you can actually unlearn it again and just don't worry about that, unless you are introducing new API (which requires a minor version bump).

Furthermore I added a reference to the fixed issue in the commit message.
If you add the following line e.g. in the initial message GH will link this PR to the issue and will close that latter if this is submitted:
Fixes #2576

With that this is ready, thanks again. :)

HannesWell · 2024-12-06T22:55:38Z

Test failures, due to OOM errors are unrelated -> Submitting this.

The "Show View" as well as the "Import" and "Export" wizards now support searching by category, rather than only by entry. eclipse-platform/eclipse.platform.ui#2576 eclipse-platform/eclipse.platform.ui#2579 eclipse-platform/eclipse.platform.ui#2602

The "Show View" as well as the "Import" and "Export" wizards now support filtering by category, rather than only by entry. eclipse-platform/eclipse.platform.ui#2576 eclipse-platform/eclipse.platform.ui#2579 eclipse-platform/eclipse.platform.ui#2602

ptziegler force-pushed the issue2576 branch from 668221e to 53d57fa Compare December 3, 2024 17:50

ptziegler force-pushed the issue2576 branch from 53d57fa to a95e6b0 Compare December 4, 2024 06:52

jukzi added enhancement New feature or request regression labels Dec 4, 2024

vogella force-pushed the issue2576 branch 2 times, most recently from 5ae0412 to a0e03bf Compare December 6, 2024 15:52

HannesWell approved these changes Dec 6, 2024

View reviewed changes

...e4.ui.workbench.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewPatternFilter.java Outdated Show resolved Hide resolved

ptziegler force-pushed the issue2576 branch from 8dc5fc1 to 242001c Compare December 6, 2024 18:00

HannesWell requested changes Dec 6, 2024

View reviewed changes

...e4.ui.workbench.swt/src/org/eclipse/e4/ui/workbench/swt/internal/copy/ViewPatternFilter.java Show resolved Hide resolved

HannesWell force-pushed the issue2576 branch 2 times, most recently from 08f1043 to 9411292 Compare December 6, 2024 21:55

HannesWell force-pushed the issue2576 branch from 9411292 to fea67d9 Compare December 6, 2024 21:56

Version bump(s) for 4.35 stream

d5d2aa9

HannesWell approved these changes Dec 6, 2024

View reviewed changes

HannesWell merged commit f0e5533 into eclipse-platform:master Dec 6, 2024
11 of 13 checks passed

ptziegler deleted the issue2576 branch January 14, 2025 18:57

ptziegler mentioned this pull request Jan 21, 2025

Add news & noteworthy entry regarding "Filter by Category" eclipse-platform/www.eclipse.org-eclipse#267

Merged

Restore ability to filter views by category #2579

Restore ability to filter views by category #2579

Uh oh!

Conversation

ptziegler commented Dec 3, 2024 • edited by HannesWell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ptziegler commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eclipse-platform-bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

vogella commented Dec 4, 2024

Uh oh!

ptziegler commented Dec 6, 2024

Uh oh!

HannesWell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HannesWell commented Dec 6, 2024

Uh oh!

ptziegler commented Dec 6, 2024

Uh oh!

HannesWell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HannesWell left a comment

Choose a reason for hiding this comment

Uh oh!

HannesWell commented Dec 6, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ptziegler commented Dec 3, 2024 •

edited by HannesWell

Loading

ptziegler commented Dec 3, 2024 •

edited

Loading

eclipse-platform-bot commented Dec 3, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

HannesWell left a comment •

edited

Loading