Skip to content

Implement search-by-category for Import/Export wizard #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Implement search-by-category for Import/Export wizard #2602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions ...g.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/WizardPatternFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2005, 2015 IBM Corporation and others.
* Copyright (c) 2005, 2024 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -15,8 +15,11 @@
package org.eclipse.ui.internal.dialogs;

import java.util.ArrayList;
import java.util.function.Function;
import java.util.stream.Stream;
import org.eclipse.jface.viewers.Viewer;
import org.eclipse.ui.dialogs.PatternFilter;
import org.eclipse.ui.wizards.IWizardCategory;

/**
* A class that handles filtering wizard node items based on a supplied matching
Expand All @@ -39,27 +42,21 @@ public boolean isElementSelectable(Object element) {

@Override
protected boolean isLeafMatch(Viewer viewer, Object element) {
if (element instanceof WizardCollectionElement) {
return false;
}

if (element instanceof WorkbenchWizardElement) {
WorkbenchWizardElement desc = (WorkbenchWizardElement) element;
String text = desc.getLabel();
if (wordMatches(text)) {
return true;
}
String wizDesc = desc.getDescription();
if (wordMatches(wizDesc)) {
return true;
}
return element instanceof WorkbenchWizardElement desc &&
Stream.of(getWizardCategories(desc.getCategory()), //
Stream.of(desc.getLabel(), desc.getDescription()), //
Stream.of(desc.getKeywordLabels())) //
// Only works for finite streams
.flatMap(Function.identity())
.anyMatch(this::wordMatches);
}

for (String keywordLabel : desc.getKeywordLabels()) {
if (wordMatches(keywordLabel))
return true;
}
private Stream<String> getWizardCategories(IWizardCategory category) {
if (category == null) {
return Stream.empty();
}
return false;
return Stream.iterate(category, current -> current.getParent() != null, IWizardCategory::getParent)
.map(IWizardCategory::getLabel);
}

@Override
Expand Down
Loading