Implement search-by-category for Import/Export wizard

[ptziegler]

This adapts the WizardPatternFilter to also show the wizards, if the search string matches one of its containing categories.

Amends 532c0fb
Fixes #2576

[vogella]

LGTM, tested it and works perfectly.

[ptziegler]

Example:

Note that there is a special implementation for the content provider which flattens categories with only a single child:

This behavior is intentional, but whether it's a "good" behavior is a different question...

eclipse.platform.ui/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/WizardContentProvider.java

Lines 49 to 52 in 1876695

	// flatten lists with only one category
	if (list.size() == 1 && list.get(0) instanceof WizardCollectionElement) {
	return getChildren(list.get(0));
	}

[vogella]

This behavior is intentional, but whether it's a "good" behavior is a different question...

So you suggest to remove this flattening?

[ptziegler]

So you suggest to remove this flattening?

That would be my preference because the current behavior is not very intuitive. A WizardCollectionElement is flattened, if it doesn't have any other siblings. So the visibility of an element depends on your search string.

I found it confusion when Test Import Add To Parent Category was no longer a direct child of General after clearing the filter, even though that's exactly what the viewer told me.

However, this has been the behavior for over 20 years without any complaints. So I don't think the current behavior is wrong and if it is changed, then only as part of a separate commit.

[vogella]

That would be my preference because the current behavior is not very intuitive. A WizardCollectionElement is flattened, if it doesn't have any other siblings. So the visibility of an element depends on your search string.

I agree that we should remove this special treatment, I think consistent behavior is the UI is important. As you already into the code, please provide a separate PR for this adjustment.

[vogella]

Linux builds seem to fail always unrelated to the actual change so I will assume that this is not related to this particular change.

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.ui.views.properties.tabbed: Execute ApiApplication failed

[vogella]

Linux build issue reported here: #2603

[github-actions]

Test Results

 1 214 files   -   306   1 214 suites   - 306   1h 21m 39s ⏱️ - 12m 0s
 7 729 tests ±    0   7 495 ✅  -     6  233 💤 + 5  1 ❌ +1 
16 232 runs   - 6 456  15 716 ✅  - 6 419  515 💤  - 38  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 50a19d6. ± Comparison against base commit 1876695.

This pull request skips 5 tests.

org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

[ptziegler]

Linux builds seem to fail always unrelated to the actual change so I will assume that this is not related to this particular change.

org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:4.0.10:verify (verify) on project org.eclipse.ui.views.properties.tabbed: Execute ApiApplication failed

The builds really are flaky... 😦

As you already into the code, please provide a separate PR for this adjustment.

#2604

[vogella]

The search test failure on Mac also seems unrelated, I checked them and I do not see the Wizard involved. Merging this one.

[vogella]

@ptziegler thanks, works great in todays I-Build. I think this is a notable feature, can you add it to N&N 4.5? I think the repo for this is: https://github.com/eclipse-platform/www.eclipse.org-eclipse?tab=readme-ov-file