Skip to content

[Dark Theme] Fix for highlight issue in sub-tabs #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[Dark Theme] Fix for highlight issue in sub-tabs #2639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bundles/org.eclipse.ui.themes/css/dark/e4-dark_tabstyle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,11 @@ CTabFolder {
CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616; /* Bug 465711 */
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #316c9b;
swt-selected-highlight-top: false;
}


CTabFolder.active {
swt-selected-tab-highlight: #316c9b;
swt-selected-highlight-top: false;
Expand Down
28 changes: 16 additions & 12 deletions bundles/org.eclipse.ui.themes/css/e4-dark_linux.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,28 @@ ImageBasedFrame,
swt-selected-highlight-top: false;
}

.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #a6a6a6;
swt-selected-highlight-top: true;
}
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #2b97d7;
swt-selected-highlight-top: true;
}

/*text color of selected tab in editor */
#org-eclipse-ui-editorss CTabItem:selected{
color: '#FFFFFF';
}

#org-eclipse-ui-editorss CTabFolder{
swt-selected-tab-fill : '#1E1F22';
swt-selected-tab-highlight: '#a6a6a6';
swt-selected-highlight-top: true;
swt-draw-custom-tab-content-background: true;
swt-unselected-hot-tab-color-background:#161616;
Expand All @@ -98,19 +112,9 @@ swt-selected-tab-highlight: '#a6a6a6';
swt-selected-highlight-top: true;
}

CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-selected-tab-fill: #1E1F22;
swt-unselected-tabs-color: #48484c;
swt-unselected-hot-tab-color-background: #2f2f2f;
swt-selected-tab-highlight: #2b79d7;
swt-selected-highlight-top: false;
}

.Editor Form Composite,
.Editor Form Composite Tree,
.MPartStack.active .Editor Form Composite Tree
{
background-color: #1E1F22;
}
}
29 changes: 16 additions & 13 deletions bundles/org.eclipse.ui.themes/css/e4-dark_mac.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,28 @@ Button {
swt-selected-highlight-top: false;
}

.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #a6a6a6;
swt-selected-highlight-top: true;
}
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #2b97d7;
swt-selected-highlight-top: true;
}

/*text color of selected tab in editor */
#org-eclipse-ui-editorss CTabItem:selected{
color: '#FFFFFF';
}

#org-eclipse-ui-editorss CTabFolder{
swt-selected-tab-fill : '#1E1F22';
swt-selected-tab-highlight: '#a6a6a6';
swt-selected-highlight-top: true;
swt-draw-custom-tab-content-background: true;
swt-unselected-hot-tab-color-background:#161616;
Expand All @@ -84,20 +98,9 @@ Button {
swt-selected-highlight-top: true;
}

CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-selected-tab-fill: #1E1F22;
swt-unselected-tabs-color: #48484c;
swt-unselected-hot-tab-color-background: #2f2f2f;
swt-selected-tab-highlight: #2b79d7;
swt-selected-highlight-top: false;
}

.Editor Form Composite,
.Editor Form Composite Tree,
.MPartStack.active .Editor Form Composite Tree
{
background-color: #1E1F22;
}

}
30 changes: 17 additions & 13 deletions bundles/org.eclipse.ui.themes/css/e4-dark_win.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,33 +148,37 @@ ImageBasedFrame,
swt-selected-highlight-top: false;
}

.MPartStack CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #a6a6a6;
swt-selected-highlight-top: true;
}
.MPartStack.active CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-unselected-hot-tab-color-background: #161616;/* Bug 465711 */
swt-selected-tab-highlight: #2b97d7;
swt-selected-highlight-top: true;
}

/*text color of selected tab in editor */
#org-eclipse-ui-editorss CTabItem:selected{
color: '#FFFFFF';
}

#org-eclipse-ui-editorss CTabFolder{
swt-selected-tab-fill : '#1E1F22';
swt-selected-tab-highlight: '#a6a6a6';
swt-selected-highlight-top: true;
swt-draw-custom-tab-content-background: true;
swt-unselected-hot-tab-color-background:#161616;
swt-unselected-hot-tab-color-background:#161616;
}

#org-eclipse-ui-editorss CTabFolder.active {
swt-selected-tab-highlight: '#2b79d7';
swt-selected-highlight-top: true;
}

CTabFolder[style~='SWT.DOWN'][style~='SWT.BOTTOM'] {
/* Set the styles for the bottom inner tabs (Bug 430051): */
swt-tab-renderer: url('bundleclass://org.eclipse.e4.ui.workbench.renderers.swt/org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering');
swt-selected-tab-fill: #1E1F22;
swt-unselected-tabs-color: #48484c;
swt-unselected-hot-tab-color-background: #2f2f2f;
swt-selected-tab-highlight: #2b79d7;
swt-selected-highlight-top: false;
}
}

.Editor Form Composite,
.Editor Form Composite Tree,
Expand Down
Loading