[Dark Theme] Fix for highlight issue in sub-tabs

[mvm-sap]

With the dark theme changes, selected sub-tabs in the editor and views were missing blue highlights. This has been fixed with this PR. The screenshots below are from Windows. The same change has been incorporated in Mac and Linux.

Before:

After:

[github-actions]

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 34m 43s ⏱️ + 2m 35s
 7 734 tests ±0   7 506 ✅ +1  228 💤 ±0  0 ❌ ±0 
24 363 runs  ±0  23 614 ✅ +1  749 💤 ±0  0 ❌ ±0 

Results for commit 496e376. ± Comparison against base commit 2de3957.

♻️ This comment has been updated with latest results.

[BeckerWdf]

I manually tested this. Works fine an fixes the bug.

I see that the changes are the same on all 3 platforms (CSS rules are identical).
Can't we then simply move this into the e4-dark_globalstyle.css only once instead of duplicating it three times?

[mvm-sap]

I manually tested this. Works fine an fixes the bug.

I see that the changes are the same on all 3 platforms (CSS rules are identical). Can't we then simply move this into the e4-dark_globalstyle.css only once instead of duplicating it three times?

Okay, I shall try to move and test again

[BeckerWdf]

I manually tested this. Works fine an fixes the bug.

I see that the changes are the same on all 3 platforms (CSS rules are identical). Can't we then simply move this into the e4-dark_globalstyle.css only once instead of duplicating it three times?

or in e4-dark_tabstyle.css

[BeckerWdf]

The current state of the PR does not work correctly on macOS:

[BeckerWdf]

does not work on macOS

[mvm-sap]

does not work on macOS

I'm not sure why it isn't working. Shall I revert to a previous commit that made changes in all three platforms and worked fine? I don't have a MAC to test or debug, hence the problem.

[BeckerWdf]

It's only the last change moving it to a common file that did not work. Your initial commit worked.

[mvm-sap]

It's only the last change moving it to a common file that did not work. Your initial commit worked.

Shall I revert it back to the changes done in initial commit ?

[BeckerWdf]

It's only the last change moving it to a common file that did not work. Your initial commit worked.

Shall I revert it back to the changes done in initial commit ?

yes

[mvm-sap]

It's only the last change moving it to a common file that did not work. Your initial commit worked.

Shall I revert it back to the changes done in initial commit ?

yes

Could you please test again and confirm if its working?

[BeckerWdf]

Works fine on macOS