Skip to content

Conversation

@mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Jan 3, 2025

The breadcrumb in the source code editor had a grey background. With the new light theme changes, the background color of the breadcrumbs has also been changed to white.

Before:
Screenshot 2025-01-03 115958

After:
Screenshot 2025-01-03 120351

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 30m 54s ⏱️ -23s
 7 733 tests ±0   7 505 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 360 runs  ±0  23 611 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 7c2ebb5. ± Comparison against base commit 904bdd7.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the light_theme_breadcrumb_issue_fix branch from 29df631 to b2b8542 Compare January 8, 2025 11:39
@vogella vogella force-pushed the light_theme_breadcrumb_issue_fix branch from b2b8542 to 7c2ebb5 Compare January 14, 2025 12:16
@vogella
Copy link
Contributor

vogella commented Jan 14, 2025

@mvm-sap can you please test and merge if you agree with the change?

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Jan 15, 2025

@mvm-sap can you please test and merge if you agree with the change?

@BeckerWdf has to merge I guess

@vogella
Copy link
Contributor

vogella commented Jan 15, 2025

@BeckerWdf can you test this?

@BeckerWdf
Copy link
Member

I will have a look

@BeckerWdf
Copy link
Member

not needed any more as #1704 will fix this.

@BeckerWdf BeckerWdf closed this Jan 22, 2025
@mvm-sap mvm-sap deleted the light_theme_breadcrumb_issue_fix branch January 23, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants