Correct activation of monitor-specific rescaling on Windows #2689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
correct-monitor-specific-scaling-activation
branch
from
45483b1 to
55892dc
Compare
Contributor
Author
Contributor
Test Results 1 818 files ±0 1 818 suites ±0 1h 32m 15s ⏱️ +58s For more details on these failures, see this check. Results for commit 19e3364. ± Comparison against base commit 904bdd7. ♻️ This comment has been updated with latest results. |
fedejeanne
reviewed
Jan 14, 2025
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
fedejeanne
reviewed
Jan 14, 2025
Member
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
Looks good and works as expected, I only have 2 minor comments regarding coding practices.
bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
The activation of monitor-specific rescaling on Windows currently relies on the method Display#setRescalingAtRuntime(), which was found to not take the full intended effect. This change thus replaces the call to that method based on the value of the according experimental preference by setting the according system property to activate that behavior in a proper way. It also removes the obsolete activation of Edge when the experimental preference is set, as Edge has been enabled by default.
HeikoKlare
force-pushed
the
correct-monitor-specific-scaling-activation
branch
from
55892dc to
19e3364
Compare
Contributor
|
Looks good to me as well. |
Contributor
Author
|
Required SWT PR has been merged. Failing test is unrelated and documented: #867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activation of monitor-specific rescaling on Windows currently relies on the method Display#setRescalingAtRuntime(), which was found to not take the full intended effect.
This change thus replaces the call to that method based on the value of the according experimental preference by setting the according system property to activate that behavior in a proper way. It also removes the obsolete activation of Edge when the experimental preference is set, as Edge has been enabled by default.
Adapts to eclipse-platform/eclipse.platform.swt#1720
Requires eclipse-platform/eclipse.platform.swt#1719