Remove stacktrace from DataFormatException but add raw value #2521

[jukzi]

looks less scary

#2521

[laeubi]

This seem to loose any way to find our what is wrong here...

[jukzi]

This seem to loose any way to find our what is wrong here...

there is nothing wrong. if you wanted to debug the thing you still can as the error message is unique:

[laeubi]

there is nothing wrong.

Why do we log a message if nothing is wrong?

In your screenshot it says can't parse value but why? So I would expect some kind of number format exception, wrong values, missing comma, ....

[jukzi]

In your screenshot it says can't parse value but why? So I would expect some kind of number format exception, wrong values, missing comma, ....

??? that was not given before either. now you at least see the bad value in the logging.

[laeubi]

It would of course help to see the full exception message/trace before.... from the mentioned codepath it could handle different cases and some might contain a useful message.

[jukzi]

There are literally 0 bugs in bugzilla and github about any DataFormatException. so no one ever needed such stacktrace

[laeubi]

There are literally 0 bugs in bugzilla and github about any DataFormatException. so no one ever needed such stacktrace

Or everyone was able to fix the issue just from the stack-trace before ;-)

[github-actions]

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 43m 37s ⏱️ + 7m 50s
 7 733 tests ±0   7 505 ✅ ±0  228 💤 ±0  0 ❌ ±0 
24 360 runs  ±0  23 611 ✅ ±0  749 💤 ±0  0 ❌ ±0 

Results for commit 4fd5554. ± Comparison against base commit 74efba4.

[akurtakov]

ECA is failing for submitter now and there was disagreement how to handle this one. Closing.