Skip to content

Remove stacktrace from DataFormatException but add raw value #2521 #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −4
Closed

Remove stacktrace from DataFormatException but add raw value #2521 #2696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...es/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/themes/ColorDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
package org.eclipse.ui.internal.themes;

import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.e4.ui.internal.css.swt.definition.IColorDefinitionOverridable;
import org.eclipse.jface.resource.DataFormatException;
import org.eclipse.swt.graphics.RGB;
import org.eclipse.ui.IPluginContribution;
import org.eclipse.ui.internal.misc.StatusUtil;
import org.eclipse.ui.statushandlers.StatusManager;
import org.eclipse.ui.themes.ColorUtil;

Expand Down Expand Up @@ -111,8 +111,8 @@ public RGB getValue() {
parsedValue = ColorUtil.getColorValue(rawValue);
} catch (DataFormatException e) {
parsedValue = DEFAULT_COLOR_VALUE;
IStatus status = StatusUtil.newStatus(IStatus.WARNING,
"Could not parse value for theme color " + getId(), e); //$NON-NLS-1$
IStatus status = Status
.warning("Could not parse value for theme color " + getId() + ": \"" + rawValue + "\""); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
StatusManager.getManager().handle(status, StatusManager.LOG);
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/org.eclipse.ui.tests/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2621,7 +2621,7 @@
</colorDefinition>
<colorDefinition
label="badColor3"
value="0,0, 1x"
value="0,0, 1IntentionalBadColor3inorg.eclipse.ui.tests/plugin.xml"
id="badColor3">
</colorDefinition>
<fontDefinition
Expand Down
Loading