Simple example of a dummy e4 editor addition, which is contributed via a Model Fragment #2766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a a Model Fragment.
laeubi
reviewed
Jan 30, 2025
Contributor
laeubi
left a comment
laeubi
left a comment
There was a problem hiding this comment.
Thanks for the example I think in gernal it is good but ther is no need to name it "dummy" :-)
| import org.eclipse.swt.widgets.Composite; | ||
| import org.eclipse.swt.widgets.Text; | ||
|
|
||
| public class DummyEditor { |
Contributor
There was a problem hiding this comment.
Suggested change
| public class DummyEditor { | |
| public class ExampleE4Editor { | |
Contributor
Author
There was a problem hiding this comment.
Modified as suggested in latest version.
| @PostConstruct | ||
| public void postConstruct(Composite parent) { | ||
| Text label = new Text(parent, SWT.ITALIC); | ||
| label.setText("Dummy Editor Content..."); |
Contributor
There was a problem hiding this comment.
Suggested change
| label.setText("Dummy Editor Content..."); | |
| label.setText("E4 Editor Content..."); | |
Contributor
Author
There was a problem hiding this comment.
Modified as suggested in latest version.
Contributor
Contributor
Author
:) OK makes sense, I'll remove the 'dummy' references throughout.. and update the PR |
… to 'dummy' throughout to be replaced with 'e4', including the plugin name itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created in response to the suggestion from @laeubi in the Issue #2764