Adjusting the Size of Splash Shell a/c to image

[ShahzaibIbrahim]

The splash is initialized by the Equinox native launcher while image is set by SWT. SWT uses "correctly scaled images". This inconsistency leads to image cut off during start up.

Proposed Solution

We are adjusting the size of the shell with the size of the image in case of inconsistency.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From acd2a979162c05269c6a0dbd468544a09ca0486a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 5 Mar 2025 12:21:34 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
index 4401f18cb5..b021196aa6 100644
--- a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true
-Bundle-Version: 3.135.0.qualifier
+Bundle-Version: 3.135.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.WorkbenchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 17068c83da65caa70aac61ef57c5a82b7f5f26e7 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 5 Mar 2025 12:27:20 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
index 4401f18cb5..b021196aa6 100644
--- a/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.workbench; singleton:=true
-Bundle-Version: 3.135.0.qualifier
+Bundle-Version: 3.135.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.WorkbenchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

0 files   -  1 818  0 suites   - 1 818   0s ⏱️ - 1h 31m 23s
0 tests  -  7 721  0 ✅  -  7 493  0 💤  - 228  0 ❌ ±0 
0 runs   - 24 324  0 ✅  - 23 575  0 💤  - 749  0 ❌ ±0 

Results for commit b031b81. ± Comparison against base commit b2a5c1a.

[HeikoKlare]

To precise about the issue: if I am not mistaken, this only happens with monitor-specific scaling enabled (or even when only quarter scaling is activated).

[HeikoKlare]

Isn't the issue that the image is too large/small for the shell (because Platform UI applies quarter scaling while Equinox native launcher uses integer200) and not that the shell does not fit to the image? Changing the shell size here will result in a rescaling of the splash during application startup, won't it?

[fedejeanne]

This PR currently resizes the shell to fit the image (see GIF below, made in a 125% monitor):

I'm in favor of keeping the initial size of the shell.