Skip to content

Adjusting the Size of Splash Shell a/c to image #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShahzaibIbrahim wants to merge 1 commit into from
Closed

Adjusting the Size of Splash Shell a/c to image #2828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/Workbench.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,8 +820,14 @@ public void run() throws Exception {

if (splashShell == null)
return;
if (background != null)
if (background != null) {
splashShell.setBackgroundImage(background);
Rectangle imageBounds = background.getBounds();
Rectangle shellBounds = splashShell.getBounds();
if (imageBounds.width > shellBounds.width || imageBounds.height > shellBounds.height) {
splashShell.setSize(imageBounds.width, imageBounds.height);
Copy link
Contributor

@HeikoKlare HeikoKlare Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the issue that the image is too large/small for the shell (because Platform UI applies quarter scaling while Equinox native launcher uses integer200) and not that the shell does not fit to the image? Changing the shell size here will result in a rescaling of the splash during application startup, won't it?

}
}
}

Dictionary<String, Object> properties = new Hashtable<>();
Expand Down
Loading