Skip to content

Conversation

@ptziegler
Copy link
Contributor

The "parent" field is not set properly for the e4 FilteredTree and FilteredTable when using the protected constructor. Move the assignment to the common base class to avoid undesirable NullPointerExceptions.

Amends 176f503

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 99bee9652e92fd78bf3fe026ea01d6895adc1330 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Thu, 6 Mar 2025 18:36:42 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.jface/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
index c0a6a166d2..c66e495151 100644
--- a/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface;singleton:=true
-Bundle-Version: 3.36.0.qualifier
+Bundle-Version: 3.36.100.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.jface,
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 29m 57s ⏱️ + 1m 38s
 7 900 tests ±0   7 672 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 787 runs  ±0  23 039 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit c994345. ± Comparison against base commit 2608e53.

♻️ This comment has been updated with latest results.

ptziegler and others added 2 commits March 7, 2025 21:26
The "parent" field is not set properly for the e4 FilteredTree and
FilteredTable when using the protected constructor. Move the assignment
to the common base class to avoid undesirable NullPointerExceptions.

Amends 176f503
@ptziegler ptziegler force-pushed the parent-assignment-in-filtered-tree branch from 7f58ad0 to c994345 Compare March 7, 2025 20:26
@ptziegler ptziegler merged commit 139fb8c into eclipse-platform:master Mar 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants