Skip to content

Move FilteredTree parent assignment to abstract base class #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Move FilteredTree parent assignment to abstract base class #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b104f
Move FilteredTree parent assignment to abstract base class
ptziegler Mar 6, 2025
c994345
Version bump(s) for 4.36 stream
eclipse-platform-bot Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.jface/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.jface;singleton:=true
Bundle-Version: 3.36.0.qualifier
Bundle-Version: 3.36.100.qualifier
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Export-Package: org.eclipse.jface,
Expand Down
1 change: 1 addition & 0 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractFilteredViewerComposite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public abstract class AbstractFilteredViewerComposite<T extends ViewerFilter> ex
*/
public AbstractFilteredViewerComposite(Composite parent, int style, long refreshJobDelayInMillis) {
super(parent, style);
this.parent = parent;
this.refreshJobDelayInMillis = refreshJobDelayInMillis;
}

Expand Down
3 changes: 0 additions & 3 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/FilteredTree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ public class FilteredTree extends AbstractFilteredViewerComposite<PatternFilter>
*/
public FilteredTree(Composite parent, boolean useNewLook, boolean useFastHashLookup) {
super(parent, SWT.NONE, DEFAULT_REFRESH_TIME);
this.parent = parent;
if (treeViewer != null) {
treeViewer.setUseHashlookup(useFastHashLookup);
}
Expand Down Expand Up @@ -180,7 +179,6 @@ public FilteredTree(Composite parent, int treeStyle, PatternFilter filter, boole
public FilteredTree(Composite parent, int treeStyle, PatternFilter filter, boolean useNewLook,
boolean useFastHashLookup, long refreshJobDelayInMillis) {
super(parent, SWT.NONE, refreshJobDelayInMillis);
this.parent = parent;
init(treeStyle, filter);
if (treeViewer != null) {
treeViewer.setUseHashlookup(useFastHashLookup);
Expand Down Expand Up @@ -211,7 +209,6 @@ public FilteredTree(Composite parent, int treeStyle, PatternFilter filter, boole
@Deprecated
protected FilteredTree(Composite parent) {
super(parent, SWT.NONE, DEFAULT_REFRESH_TIME);
this.parent = parent;
}

/**
Expand Down
Loading