Skip to content

Add SVGs to org.eclipse.jface bundles #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Michael5601
Copy link
Contributor

This PR adds SVGs for all icons in the bundles org.eclipse.jface, org.eclipse.jface.text and org.eclipse.jface.notifications.

See also this PR for more information.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 6d76232e0aec538c258a586c1f7a977dc423aaeb Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 15 Apr 2025 12:36:34 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
index 7db243f2bb..13b09d3dad 100644
--- a/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
@@ -4,7 +4,7 @@ Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Bundle-SymbolicName: org.eclipse.jface.notifications
-Bundle-Version: 0.7.300.qualifier
+Bundle-Version: 0.7.400.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Export-Package: org.eclipse.jface.notifications,
  org.eclipse.jface.notifications.internal;x-internal:=true
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 15, 2025

Test Results

 1 824 files  + 1 756   1 824 suites  +1 756   1h 39m 16s ⏱️ + 1h 38m 56s
 7 918 tests + 6 204   7 690 ✅ + 5 994  228 💤 +210  0 ❌ ±0 
23 841 runs  +22 111  23 093 ✅ +21 381  748 💤 +730  0 ❌ ±0 

Results for commit c9cffa6. ± Comparison against base commit 6683c3f.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare force-pushed the org.eclipse.jface.SVGs branch from a0f4c7d to b77db42 Compare April 20, 2025 08:01
@HeikoKlare HeikoKlare force-pushed the org.eclipse.jface.SVGs branch from b77db42 to 5c8fdda Compare April 24, 2025 15:20
Michael5601 and others added 2 commits April 26, 2025 15:27
This commit adds all svgs to the bundles `org.eclipse.jface`,  `org.eclipse.jface.text` and  `org.eclipse.jface.notifications`.
@HeikoKlare HeikoKlare force-pushed the org.eclipse.jface.SVGs branch from 5c8fdda to c9cffa6 Compare April 26, 2025 13:27
@HeikoKlare HeikoKlare merged commit 34f7cde into eclipse-platform:master Apr 26, 2025
11 checks passed
@Michael5601 Michael5601 deleted the org.eclipse.jface.SVGs branch April 26, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants