Skip to content

Add SVGs to org.eclipse.jface bundles #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bundles/org.eclipse.jface.notifications/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ Bundle-Name: %pluginName
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Bundle-SymbolicName: org.eclipse.jface.notifications
Bundle-Version: 0.7.300.qualifier
Bundle-Version: 0.7.400.qualifier
Bundle-RequiredExecutionEnvironment: JavaSE-17
Export-Package: org.eclipse.jface.notifications,
org.eclipse.jface.notifications.internal;x-internal:=true
Automatic-Module-Name: org.eclipse.jface.notifications
Require-Bundle: org.eclipse.core.runtime;bundle-version="3.29.0",
org.eclipse.jface;bundle-version="3.20.0"
Require-Capability: eclipse.swt;filter:="(image.format=svg)"
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ public class CommonImages {

private static final String T_EVIEW = "eview16"; //$NON-NLS-1$

public static final ImageDescriptor NOTIFICATION_CLOSE = create(T_EVIEW, "notification-close.png"); //$NON-NLS-1$
public static final ImageDescriptor NOTIFICATION_CLOSE_HOVER = create(T_EVIEW, "notification-close-active.png"); //$NON-NLS-1$
public static final ImageDescriptor NOTIFICATION_CLOSE = create(T_EVIEW, "notification-close.svg"); //$NON-NLS-1$
public static final ImageDescriptor NOTIFICATION_CLOSE_HOVER = create(T_EVIEW, "notification-close-active.svg"); //$NON-NLS-1$

private static ImageDescriptor create(String prefix, String name) {
try {
Expand Down
1 change: 1 addition & 0 deletions bundles/org.eclipse.jface.text/META-INF/MANIFEST.MF
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ Require-Bundle:
Import-Package: com.ibm.icu.text
Bundle-RequiredExecutionEnvironment: JavaSE-17
Automatic-Module-Name: org.eclipse.jface.text
Require-Capability: eclipse.swt;filter:="(image.format=svg)"
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,9 @@ private Image getImage(Display display) {
private void initializeImages(Display display) {
if (fgCollapsedImage == null) {

ImageDescriptor descriptor= ImageDescriptor.createFromFile(ProjectionAnnotation.class, "images/collapsed.png"); //$NON-NLS-1$
ImageDescriptor descriptor= ImageDescriptor.createFromFile(ProjectionAnnotation.class, "images/collapsed.svg"); //$NON-NLS-1$
fgCollapsedImage= descriptor.createImage(display);
descriptor= ImageDescriptor.createFromFile(ProjectionAnnotation.class, "images/expanded.png"); //$NON-NLS-1$
descriptor= ImageDescriptor.createFromFile(ProjectionAnnotation.class, "images/expanded.svg"); //$NON-NLS-1$
fgExpandedImage= descriptor.createImage(display);
display.disposeExec(new DisplayDisposeRunnable());
}
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading