Fix flaky ProgressContantsTest.testKeepOneProperty race condition #3523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #370 - The
testKeepOnePropertytest was failing randomly due to timing issues when multiple jobs withKEEPONE_PROPERTYfinish simultaneously.Problem
The test exhibited flaky behavior where it would:
The root cause was a race condition in the test's timing logic when 20 jobs with
KEEPONE_PROPERTYfinish at the same time.Solution
Made three key improvements to eliminate the race condition:
job.inProgressis true) with a 3000ms timeoutprocessEvents()call after jobs complete to ensure job completion events are handledprocessEvents()call after the marker error job appears to ensure all KEEPONE cleanup logic has completedChanges
File:
tests/org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/progress/ProgressContantsTest.javaprocessEventsUntil(null, 500)with condition-based waitingprocessEvents()afterjoinJobs()processEvents()after marker job appearsTesting
ProgressContantsTestclass - all passedTest Plan
🤖 Generated with Claude Code