Fix flaky PartRenderingEngineTests.ensureCleanUpAddonCleansUp race condition #3537
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition The test was failing intermittently with "CleanupAddon should ensure that partStack is not rendered anymore, as all childs have been removed" because it was checking the cleanup result before the async cleanup logic had a chance to execute. Root cause: - CleanupAddon performs cleanup asynchronously via Display.asyncExec() (CleanupAddon.java:352) - When hidePart() is called, it triggers events that schedule async cleanup tasks on the event queue - The test was calling waitForCondition() immediately after hiding parts, before the async cleanup tasks were even posted to the event queue - This created a race where the wait could timeout before cleanup started Fix: - Add contextRule.spinEventLoop() after hiding partB and partC to ensure async cleanup tasks are processed before waiting for the condition - Wrap waitForCondition() in assertTrue() to fail immediately with a clear message if cleanup doesn't complete within timeout - Remove redundant assertFalse() statements This matches the pattern used in the adjacent testBug332463 test which calls spinEventLoop() after each hidePart() call. Verified with 5 consecutive test runs - all passed (consistently completing in ~0.028-0.036s). Fixes eclipse-platform#751 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
vogella
force-pushed
the
fix-flaky-cleanup-addon-test
branch
from
9dc35d9 to
8ad3ee0
Compare
Contributor
Contributor
Author
|
@ptziegler WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
PartRenderingEngineTests.ensureCleanUpAddonCleansUptest that was failing intermittently due to a race condition with async cleanup logic.Root Cause
CleanupAddonperforms cleanup asynchronously viaDisplay.asyncExec()(CleanupAddon.java:352)waitForCondition()immediately after hiding parts, before the async cleanup tasks were even posted to the event queueChanges
contextRule.spinEventLoop()after hiding partB and partC to ensure async cleanup tasks are processed before waitingwaitForCondition()inassertTrue()for clearer error messages on timeoutassertFalse()statementsThis matches the pattern used in the adjacent
testBug332463test.Testing
Fixes #751
🤖 Generated with Claude Code