Skip to content

Fix flaky PartRenderingEngineTests.ensureCleanUpAddonCleansUp race condition #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
+4 −5
Merged

Fix flaky PartRenderingEngineTests.ensureCleanUpAddonCleansUp race condition #3537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...g.eclipse.e4.ui.tests/src/org/eclipse/e4/ui/tests/workbench/PartRenderingEngineTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2466,12 +2466,11 @@ public void ensureCleanUpAddonCleansUp() {
assertTrue(" PartStack with children should be rendered", partStackForPartBPartC.isToBeRendered());
partService.hidePart(partB);
partService.hidePart(partC);
DisplayHelper.waitForCondition(Display.getDefault(), 5_000,
() -> partStackForPartBPartC.isToBeRendered() == false);
assertFalse(
contextRule.spinEventLoop();
assertTrue(
"CleanupAddon should ensure that partStack is not rendered anymore, as all childs have been removed",
partStackForPartBPartC.isToBeRendered());
assertFalse("Part stack should be removed", partStackForPartBPartC.isToBeRendered());
DisplayHelper.waitForCondition(Display.getDefault(), 5_000,
() -> partStackForPartBPartC.isToBeRendered() == false));
// PartStack with IPresentationEngine.NO_AUTO_COLLAPSE should not be removed
// even if children are removed
partService.hidePart(editor, true);
Expand Down
Loading